From e527099b007750b08ddcdf973e51e0c9be45bdce Mon Sep 17 00:00:00 2001 From: Manuel Wiedenmann Date: Mon, 9 Apr 2018 02:26:03 +0200 Subject: [PATCH] Fix tests --- app/controllers/index.js | 2 +- tests/unit/controllers/index-test.js | 10 +++++----- .../lib/kredits/serializers/contribution-test.js | 2 +- .../unit/lib/kredits/serializers/contributor-test.js | 2 +- tests/unit/services/ipfs-test.js | 12 ------------ 5 files changed, 8 insertions(+), 20 deletions(-) delete mode 100644 tests/unit/services/ipfs-test.js diff --git a/app/controllers/index.js b/app/controllers/index.js index 4f18593..387e259 100644 --- a/app/controllers/index.js +++ b/app/controllers/index.js @@ -17,7 +17,7 @@ export default Controller.extend({ contributors: alias('model.contributors'), contributorsWithKredits: filter('contributors', function(contributor) { - return contributor.get('balance') !== 0; + return contributor.get('balance').toString() !== "0"; }), contributorsSorting: ['balance:desc'], contributorsSorted: sort('contributorsWithKredits', 'contributorsSorting'), diff --git a/tests/unit/controllers/index-test.js b/tests/unit/controllers/index-test.js index 45c2465..a0bdd28 100644 --- a/tests/unit/controllers/index-test.js +++ b/tests/unit/controllers/index-test.js @@ -8,7 +8,7 @@ const { } = Ember; moduleFor('controller:index', 'Unit | Controller | index', { - needs: ['service:ipfs', 'service:kredits'] + needs: ['service:kredits'] }); let addFixtures = function(controller) { @@ -18,10 +18,10 @@ let addFixtures = function(controller) { }); [ - { github_username: "neo", github_uid: "318", balance: 10000 }, - { github_username: "morpheus", github_uid: "843", balance: 15000 }, - { github_username: "trinity", github_uid: "123", balance: 5000 }, - { github_username: "mouse", github_uid: "696", balance: 0 } + { github_username: "neo", github_uid: "318", balance: "10000" }, + { github_username: "morpheus", github_uid: "843", balance: "15000" }, + { github_username: "trinity", github_uid: "123", balance: "5000" }, + { github_username: "mouse", github_uid: "696", balance: "0" } ].forEach(fixture => { controller.get('model.contributors').push(Contributor.create(fixture)); }); diff --git a/tests/unit/lib/kredits/serializers/contribution-test.js b/tests/unit/lib/kredits/serializers/contribution-test.js index 7d0b02a..e0f5cf1 100644 --- a/tests/unit/lib/kredits/serializers/contribution-test.js +++ b/tests/unit/lib/kredits/serializers/contribution-test.js @@ -1,7 +1,7 @@ import { module, test } from 'ember-qunit'; import schemas from 'npm:kosmos-schemas'; import tv4 from 'npm:tv4'; -import { ContributionSerializer } from 'kredits-web/lib/kredits'; +import ContributionSerializer from 'kredits-web/lib/kredits/serializers/contribution'; module('Serializers contribution'); diff --git a/tests/unit/lib/kredits/serializers/contributor-test.js b/tests/unit/lib/kredits/serializers/contributor-test.js index 9c08650..cd17b75 100644 --- a/tests/unit/lib/kredits/serializers/contributor-test.js +++ b/tests/unit/lib/kredits/serializers/contributor-test.js @@ -1,7 +1,7 @@ import { module, test } from 'ember-qunit'; import schemas from 'npm:kosmos-schemas'; import tv4 from 'npm:tv4'; -import { ContributorSerializer } from 'kredits-web/lib/kredits'; +import ContributorSerializer from 'kredits-web/lib/kredits/serializers/contributor'; module('Serializers contributor'); diff --git a/tests/unit/services/ipfs-test.js b/tests/unit/services/ipfs-test.js deleted file mode 100644 index 3a10cca..0000000 --- a/tests/unit/services/ipfs-test.js +++ /dev/null @@ -1,12 +0,0 @@ -import { moduleFor, test } from 'ember-qunit'; - -moduleFor('service:ipfs', 'Unit | Service | ipfs', { - // Specify the other units that are required for this test. - // needs: ['service:foo'] -}); - -// Replace this with your real tests. -test('it exists', function(assert) { - let service = this.subject(); - assert.ok(service); -});