kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Fix Ember not re-using DOM elements on block updates

Browse Source 
Causing serious performance issues without the stable key
This commit is contained in:
Râu Cao
2026-07-26 16:40:08 +02:00
parent 3cab203498
commit f7ee864071
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/components/contribution-list/component.js
+1
View File
@@ -73,6 +73,7 @@ export default Component.extend({
.filter(Boolean); .filter(Boolean);
return EmberObject.create({ return EmberObject.create({
key: raw.groupId || `c-${first.id}`,
groupId: raw.groupId, groupId: raw.groupId,
items, items,
contributors, contributors,
app/components/contribution-list/template.hbs
+2 -2
View File
@@ -30,7 +30,7 @@
{{/if}} {{/if}}
<ul class="item-list contribution-list {{if @loading 'loading'}}"> <ul class="item-list contribution-list {{if @loading 'loading'}}">
{{#each this.groupedContributions as |group|}} {{#each this.groupedContributions key="key" as |group|}}
{{#if group.isGrouped}} {{#if group.isGrouped}}
<li role="button" data-group-id={{group.groupId}} <li role="button" data-group-id={{group.groupId}}
{{action "toggleGroup" group}} {{action "toggleGroup" group}}
@@ -77,7 +77,7 @@
{{/each}} {{/each}}
{{/if}} {{/if}}
{{else}} {{else}}
{{#each group.items as |contribution|}} {{#each group.items key="id" as |contribution|}}
<li role="button" data-contribution-id={{contribution.id}} <li role="button" data-contribution-id={{contribution.id}}
{{action "openContributionDetails" contribution}} {{action "openContributionDetails" contribution}}
class="{{item-status contribution}}{{if (eq contribution.id @selectedContributionId) " selected"}}"> class="{{item-status contribution}}{{if (eq contribution.id @selectedContributionId) " selected"}}">