From fb66bd4f0d787a10145ca637a0a6b0d3c012e45c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A2u=20Cao?= Date: Thu, 6 Oct 2022 12:29:57 +0200 Subject: [PATCH] Fix some linter errors and warnings --- app/components/add-contribution/component.js | 2 +- app/utils/group-by.js | 5 ++--- .../components/contribution-list/component-test.js | 2 -- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/components/add-contribution/component.js b/app/components/add-contribution/component.js index 5ae1d56..a79ec5d 100644 --- a/app/components/add-contribution/component.js +++ b/app/components/add-contribution/component.js @@ -1,6 +1,6 @@ import Component from '@ember/component'; import { computed } from '@ember/object'; -import { alias, and, notEmpty } from '@ember/object/computed'; +import { and, notEmpty } from '@ember/object/computed'; import { assign } from '@ember/polyfills'; import moment from 'moment'; import { inject as service } from '@ember/service'; diff --git a/app/utils/group-by.js b/app/utils/group-by.js index 3b08a95..2847c23 100644 --- a/app/utils/group-by.js +++ b/app/utils/group-by.js @@ -2,7 +2,6 @@ // Code from https://github.com/HeroicEric/ember-group-by (MIT licensed) // import { A } from '@ember/array'; -import { get } from '@ember/object'; import { isPresent } from '@ember/utils'; export default function groupBy (collection, property) { @@ -11,11 +10,11 @@ export default function groupBy (collection, property) { if (items) { items.forEach(function(item) { - let value = get(item, property); + let value = item[property]; let group = groups.findBy('value', value); if (isPresent(group)) { - get(group, 'items').push(item); + group.items.push(item); } else { group = { property: property, value: value, items: [item] }; groups.push(group); diff --git a/tests/integration/components/contribution-list/component-test.js b/tests/integration/components/contribution-list/component-test.js index 9892cf2..b7f87ba 100644 --- a/tests/integration/components/contribution-list/component-test.js +++ b/tests/integration/components/contribution-list/component-test.js @@ -19,8 +19,6 @@ module('Integration | Component | contribution-list', function(hooks) { let kredits = this.owner.lookup('service:kredits'); kredits.set('contributors', contributors); - debugger; - this.set('fixtures', contributions); await render(hbs`{{contribution-list contributions=fixtures showQuickFilter=true}}`);