kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Do not rely on web3 injection with new ethereum provider standard #102

Merged
bumi merged 1 commits from chore/ethereum-provider into master 2019-04-10 14:19:45 +00:00
Conversation 4 Commits 1 Files Changed 1
+4 -5
bumi commented 2019-04-09 20:40:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

when window.ethereum is available web3 is likely not available as the
browser uses the new provider standard.
So we either user the window.ethereum as provider or the
web3.currentProvider as legacy option.

when window.ethereum is available web3 is likely not available as the browser uses the new provider standard. So we either user the window.ethereum as provider or the web3.currentProvider as legacy option.
raucao commented 2019-04-10 14:04:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'm not sure I understand. This is ported from the official upgrade instructions for Metamask and it comes with window.ethereum and window.Web3 (the constructor, not the instance). It is then set as web3 instance on window, so that the APIs are the same.

Am I missing something? Or is there a particular wallet that doesn't work this way perhaps?

I'm not sure I understand. This is ported from the official upgrade instructions for Metamask and it comes with `window.ethereum` and `window.Web3` (the constructor, not the instance). It is then set as `web3` instance on `window`, so that the APIs are the same. Am I missing something? Or is there a particular wallet that doesn't work this way perhaps?
bumi commented 2019-04-10 14:14:59 +00:00 (Migrated from github.com)
Copy Link
Copy Source

When I tried the app in opera I get the error that Web3 is undefined, but it injects an window.ethereum provider.
Looking at the metamask documentation here it seems that window.ethereum == window.web3.currentProvider. So there is no need to initialize another Web3 object.

It seems the new global API only injects window.ethereum and no Web3 is available. (which somehow makes sense as for example we use ethers and no full web3 is needed at all)

When I tried the app in opera I get the error that `Web3` is undefined, but it injects an `window.ethereum` provider. Looking at the [metamask documentation here](https://metamask.github.io/metamask-docs/API_Reference/Ethereum_Provider) it seems that window.ethereum == window.web3.currentProvider. So there is no need to initialize another Web3 object. It seems the new global API only injects `window.ethereum` and no Web3 is available. (which somehow makes sense as for example we use ethers and no full web3 is needed at all)
👍 1
raucao commented 2019-04-10 14:17:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Ah, I see. Thanks. 👍

Ah, I see. Thanks. :+1:
raucao (Migrated from github.com) approved these changes 2019-04-10 14:17:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#102
Delete Branch "chore/ethereum-provider"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?