kredits/kredits-web
9
0
Fork 0
Code Issues 21 Pull Requests Actions Releases 19 Activity

Update kredits-contracts #103

Merged
bumi merged 4 commits from chore/weltempfaenger-release into master 2019-04-17 09:54:35 +00:00
Conversation 6 Commits 4 Files Changed 4
+35 -121
bumi commented 2019-04-15 17:34:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This updates kredits-contracts to the latest 5.x release which contains the details for the weltempfaenger rinkeby "production" release.

once merged, we should deploy kredits-web

ToDo:

  • release new kosmos-schemas and use here.
This updates kredits-contracts to the latest 5.x release which contains the details for the weltempfaenger rinkeby "production" release. once merged, we should deploy kredits-web ### ToDo: - [x] release new kosmos-schemas and use here.
bumi commented 2019-04-15 21:36:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

can someone help me with the failing test? I guess this has something to do with the changed schema validations but I don't really know how they affect that test.

can someone help me with the failing test? I guess this has something to do with the changed schema validations but I don't really know how they affect that test.
raucao commented 2019-04-16 08:03:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The arguments are definitely not valid according to the latest schema (missing date for example). But I'm wondering why we would test this in kredits-web in the first place? This is a test for the contracts library, not the Web UI.

The arguments are definitely not valid according to the latest schema (missing `date` for example). But I'm wondering why we would test this in kredits-web in the first place? This is a test for the contracts library, not the Web UI.
fsmanuel commented 2019-04-16 09:07:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

But I'm wondering why we would test this in kredits-web in the first place?

Because we had and have no test in kredits-contracts so we put it here.

This is a test for the contracts library, not the Web UI.

Agreed!

> But I'm wondering why we would test this in kredits-web in the first place? Because we had and have no test in `kredits-contracts` so we put it here. > This is a test for the contracts library, not the Web UI. Agreed!
fsmanuel commented 2019-04-16 09:08:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi muhahahaha

@bumi muhahahaha
😆 1
fsmanuel commented 2019-04-16 10:19:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I think we can remove the kosmos-schemas dependency now.

I think we can remove the `kosmos-schemas` dependency now.
raucao commented 2019-04-17 09:54:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Updated everything and successfully tested that it works with production contributors now.

Updated everything and successfully tested that it works with production contributors now.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#103