kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Display contribution balances not token balances #107

Merged
bumi merged 3 commits from feature/use-contribution-balances into master 2019-04-24 08:57:25 +00:00
Conversation 6 Commits 3 Files Changed 8
+23 -33
bumi commented 2019-04-19 16:17:27 +00:00 (Migrated from github.com)
Copy Link
Copy Source

We want to display the contribution balances (kredits earned) of the
contributors not the token balances.

this depends on merge and deployment of: https://github.com/67P/kredits-contracts/pull/110/

We want to display the contribution balances (kredits earned) of the contributors not the token balances. this depends on merge and deployment of: https://github.com/67P/kredits-contracts/pull/110/
🚀 1
raucao (Migrated from github.com) reviewed 2019-04-23 11:08:02 +00:00
raucao (Migrated from github.com) left a comment
Copy Link
Copy Source

LGTM. Just two minor comments about form.

LGTM. Just two minor comments about form.
app/services/kredits.js
@@ -116,6 +116,12 @@ export default Service.extend({
})
raucao (Migrated from github.com) commented 2019-04-23 11:04:50 +00:00
Copy Link
Copy Source

Can be written more concise:

  .then(total => total.toNumber());
Can be written more concise: ```js .then(total => total.toNumber()); ```
app/services/kredits.js
@@ -117,2 +117,4 @@
}),
totalKreditsEarned: computed(function() {
return this.kredits.Contribution.functions.totalKreditsEarned(true)
raucao (Migrated from github.com) commented 2019-04-23 11:07:32 +00:00
Copy Link
Copy Source

Not a fan of the unnamed true in this new function call, because the meaning is completely hidden, until one finds and reads the Solidity source code of it.

Not a fan of the unnamed `true` in this new function call, because the meaning is completely hidden, until one finds and reads the Solidity source code of it.
bumi (Migrated from github.com) reviewed 2019-04-23 11:50:12 +00:00
app/services/kredits.js
@@ -117,2 +117,4 @@
}),
totalKreditsEarned: computed(function() {
return this.kredits.Contribution.functions.totalKreditsEarned(true)
bumi (Migrated from github.com) commented 2019-04-23 11:50:12 +00:00
Copy Link
Copy Source

yes, me neither. but it is a contract call and generated from the wrapper.
could at some write our own function in the wrapper class.

yes, me neither. but it is a contract call and generated from the wrapper. could at some write our own function in the wrapper class.
raucao (Migrated from github.com) reviewed 2019-04-23 12:00:03 +00:00
app/services/kredits.js
@@ -117,2 +117,4 @@
}),
totalKreditsEarned: computed(function() {
return this.kredits.Contribution.functions.totalKreditsEarned(true)
raucao (Migrated from github.com) commented 2019-04-23 12:00:03 +00:00
Copy Link
Copy Source

Ah, yes.

Ah, yes.
raucao commented 2019-04-23 13:19:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I published contracts and pushed a commit that uses the new version here. Successfully tested on my machine as well.

This can be merged as soon as it has a kredits label attached.

I published contracts and pushed a commit that uses the new version here. Successfully tested on my machine as well. This can be merged as soon as it has a kredits label attached.
bumi commented 2019-04-23 13:57:50 +00:00 (Migrated from github.com)
Copy Link
Copy Source

we need to deploy a new contract version first before we deploy this one.

we need to deploy a new contract version first before we deploy this one.
raucao commented 2019-04-23 14:01:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

we need to deploy a new contract version first before we deploy this one.

Yes, but that doesn't affect merging. And the label is still missing.

> we need to deploy a new contract version first before we deploy this one. Yes, but that doesn't affect merging. And the label is still missing.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#107
Delete Branch "feature/use-contribution-balances"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?