kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Fix/update adding contributors #108

Merged
raucao merged 2 commits from feature/add_contributor into master 2019-04-29 11:44:16 +00:00
Conversation 5 Commits 2 Files Changed 7
+42 -34
raucao commented 2019-04-25 12:25:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
bumi (Migrated from github.com) approved these changes 2019-04-25 20:32:34 +00:00
app/services/kredits.js
@@ -136,2 +140,3 @@
.then((data) => {
return this.kredits.Contributor.add(attributes, { gasLimit: 350000 })
.then(data => {
console.debug('[kredits] add contributor response', data);
bumi (Migrated from github.com) commented 2019-04-25 20:32:11 +00:00
Copy Link
Copy Source

as this is only for development we should set this manually in the metamask interface.
I have the "Advanced gas controls" setting turned on - so the gas settings form is directly displayed when the transaction needs to be confirmed. This makes it easy to change them.

as this is only for development we should set this manually in the metamask interface. I have the "Advanced gas controls" setting turned on - so the gas settings form is directly displayed when the transaction needs to be confirmed. This makes it easy to change them.
raucao (Migrated from github.com) reviewed 2019-04-25 22:18:57 +00:00
app/services/kredits.js
@@ -136,2 +140,3 @@
.then((data) => {
return this.kredits.Contributor.add(attributes, { gasLimit: 350000 })
.then(data => {
console.debug('[kredits] add contributor response', data);
raucao (Migrated from github.com) commented 2019-04-25 22:18:57 +00:00
Copy Link
Copy Source

Without this, I don't even get to the confirmation screen. The error happens beforehand, because the limit is too high.

Without this, I don't even get to the confirmation screen. The error happens beforehand, because the limit is too high.
bumi (Migrated from github.com) reviewed 2019-04-25 22:23:23 +00:00
app/services/kredits.js
@@ -136,2 +140,3 @@
.then((data) => {
return this.kredits.Contributor.add(attributes, { gasLimit: 350000 })
.then(data => {
console.debug('[kredits] add contributor response', data);
bumi (Migrated from github.com) commented 2019-04-25 22:23:23 +00:00
Copy Link
Copy Source

hmmm, will test it here again tomorrow. thought it worked for me, but maybe I was missing something.

do you have an idea how we can best handle this? because so far it seems it is some development issue - and is not needed with rinkeby.

hmmm, will test it here again tomorrow. thought it worked for me, but maybe I was missing something. do you have an idea how we can best handle this? because so far it seems it is some development issue - and is not needed with rinkeby.
raucao (Migrated from github.com) reviewed 2019-04-25 22:27:17 +00:00
app/services/kredits.js
@@ -136,2 +140,3 @@
.then((data) => {
return this.kredits.Contributor.add(attributes, { gasLimit: 350000 })
.then(data => {
console.debug('[kredits] add contributor response', data);
raucao (Migrated from github.com) commented 2019-04-25 22:27:17 +00:00
Copy Link
Copy Source

It happens to me on Rinkeby.

It happens to me on Rinkeby.
raucao commented 2019-04-29 11:43:36 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Removed WIP, because the contributor management UI is actually part of the next milestone. But this already works in general, so is good to merge.

Removed WIP, because the contributor management UI is actually part of the next milestone. But this already works in general, so is good to merge.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#108
Delete Branch "feature/add_contributor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?