Show unconfirmed balances in toplist #112

2019-04-27T16:39:50Z

raucao commented

2019-04-27 16:39:50 +00:00

(Migrated from github.com)

Calculate unconfirmed balances
Use new collection in toplist component
Allow toggling between confirmed and total amounts
Tests

closes #111

* [x] Calculate unconfirmed balances * [x] Use new collection in toplist component * [x] Allow toggling between confirmed and total amounts * [x] Tests closes #111

bumi (Migrated from github.com) approved these changes 2019-05-01 18:45:12 +00:00

bumi (Migrated from github.com) left a comment

nice, worked great on my machine!
let's merge it!

nice, worked great on my machine! let's merge it!

app/utils/group-by.js

						
				@@ -0,0 +9,4 @@

				  let groups = A();

				  let items = collection;

				  if (items) {

bumi (Migrated from github.com) commented

2019-05-01 18:43:59 +00:00

maybe
if(!items) {
return groups;
}

maybe if(!items) { return groups; }

tests/unit/controllers/index-test.js

						
				@@ -30,0 +26,4 @@

				//     assert.ok(isPresent(contributorsSorted.findBy('github_username', 'neo')));

				//     assert.ok(isEmpty(contributorsSorted.findBy('github_username', 'mouse')));

				//   });

				// });

bumi (Migrated from github.com) commented

2019-05-01 18:42:54 +00:00

are this comments still needed, or can we take it from git?

raucao (Migrated from github.com) reviewed 2019-05-01 18:51:48 +00:00

tests/unit/controllers/index-test.js

						
				@@ -30,0 +26,4 @@

				//     assert.ok(isPresent(contributorsSorted.findBy('github_username', 'neo')));

				//     assert.ok(isEmpty(contributorsSorted.findBy('github_username', 'mouse')));

				//   });

				// });

raucao (Migrated from github.com) commented

2019-05-01 18:51:48 +00:00

I think it's more convenient to leave them there. Needed again soon when adding more custom functions to the controller.

raucao (Migrated from github.com) reviewed 2019-05-01 18:53:01 +00:00

app/utils/group-by.js

						
				@@ -0,0 +9,4 @@

				  let groups = A();

				  let items = collection;

				  if (items) {

raucao (Migrated from github.com) commented

2019-05-01 18:53:01 +00:00

Did you see that you can now suggest changes to commit in code comments? It's the first icon button in the comment topbar. Makes it much easier to see what the suggested change is as well, because the code behind the comment isn't cut off then...

Never mind, it's a bigger change.

<del>Did you see that you can now suggest changes to commit in code comments? It's the first icon button in the comment topbar. Makes it much easier to see what the suggested change is as well, because the code behind the comment isn't cut off then...</del> Never mind, it's a bigger change.

raucao (Migrated from github.com) reviewed 2019-05-01 18:55:03 +00:00

app/utils/group-by.js

						
				@@ -0,0 +9,4 @@

				  let groups = A();

				  let items = collection;

				  if (items) {

raucao (Migrated from github.com) commented

2019-05-01 18:55:03 +00:00

I think a single return is a bit cleaner here.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#112