kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Fix contributor list, add kredits service tests #115

Merged
raucao merged 7 commits from bugfix/114-contributor_list into master 2019-05-08 10:35:01 +00:00
Conversation 4 Commits 7 Files Changed 4
+82 -9
raucao commented 2019-05-06 16:27:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

closes #114

closes #114
bumi (Migrated from github.com) approved these changes 2019-05-06 18:25:58 +00:00
bumi (Migrated from github.com) left a comment
Copy Link
Copy Source

LGTM!

LGTM!
galfert (Migrated from github.com) approved these changes 2019-05-08 09:09:35 +00:00
galfert (Migrated from github.com) left a comment
Copy Link
Copy Source

Just left one comment. The rest looks good to me.

Just left one comment. The rest looks good to me.
app/services/kredits.js
@@ -45,19 +45,34 @@ export default Service.extend({
});
}),
galfert (Migrated from github.com) commented 2019-05-08 09:05:51 +00:00
Copy Link
Copy Source

I think you might want to change the dependency, so the computed property updates when the vetoed status of any of the contributions changes.

   kreditsByContributor: computed('contributionsUnconfirmed.@each.vetoed', 'contributors', function() {
I think you might want to change the dependency, so the computed property updates when the `vetoed` status of any of the contributions changes. ```suggestion kreditsByContributor: computed('contributionsUnconfirmed.@each.vetoed', 'contributors', function() { ```
raucao (Migrated from github.com) reviewed 2019-05-08 09:45:19 +00:00
app/services/kredits.js
@@ -45,19 +45,34 @@ export default Service.extend({
});
}),
raucao (Migrated from github.com) commented 2019-05-08 09:45:19 +00:00
Copy Link
Copy Source

Cool. Will that still account for new and deleted objects in the collection, and changes of other properties?

Cool. Will that still account for new and deleted objects in the collection, and changes of other properties?
galfert (Migrated from github.com) reviewed 2019-05-08 10:19:31 +00:00
app/services/kredits.js
@@ -45,19 +45,34 @@ export default Service.extend({
});
}),
galfert (Migrated from github.com) commented 2019-05-08 10:19:30 +00:00
Copy Link
Copy Source

Yes, it will also update when the array itself changes (e.g. elements added or removed). If you want to add additional properties as dependencies, you would add them like this contributionsUnconfirmed.@each.{vetoed,otherProperty}.

Yes, it will also update when the array itself changes (e.g. elements added or removed). If you want to add additional properties as dependencies, you would add them like this `contributionsUnconfirmed.@each.{vetoed,otherProperty}`.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
raucao
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#115
Delete Branch "bugfix/114-contributor_list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?