kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Contributor profiles #135

Merged
raucao merged 8 commits from feature/contributor_profiles into master 2019-07-12 09:42:27 +00:00
Conversation 5 Commits 8 Files Changed 36
+360 -72
raucao commented 2019-07-11 08:04:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This adds the basic layout and functionality for rendering (linkable) details in a third column/pane, and as first addition it implements basic contributor profile cards. Account links and stats are still missing, but easy to add from here on.

See commits for some more details.

Screenshot from 2019-07-11 10-05-44

This adds the basic layout and functionality for rendering (linkable) details in a third column/pane, and as first addition it implements basic contributor profile cards. Account links and stats are still missing, but easy to add from here on. See commits for some more details. ![Screenshot from 2019-07-11 10-05-44](https://user-images.githubusercontent.com/842/61033295-777ad680-a3c3-11e9-973b-aec95be8c307.png)
raucao commented 2019-07-11 13:34:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Now also includes account links:

Screenshot from 2019-07-11 15-31-17

Now also includes account links: ![Screenshot from 2019-07-11 15-31-17](https://user-images.githubusercontent.com/842/61055287-68ab1880-a3f1-11e9-90fa-de3d0910de12.png)
galfert (Migrated from github.com) approved these changes 2019-07-12 09:35:27 +00:00
galfert (Migrated from github.com) left a comment
Copy Link
Copy Source

Very nice.

Very nice.
app/components/external-account-link/component.js
@@ -0,0 +1,15 @@
import Component from '@ember/component';
galfert (Migrated from github.com) commented 2019-07-12 09:25:07 +00:00
Copy Link
Copy Source

Necessary information? ;)

Necessary information? ;)
raucao (Migrated from github.com) reviewed 2019-07-12 09:38:47 +00:00
app/components/external-account-link/component.js
@@ -0,0 +1,15 @@
import Component from '@ember/component';
raucao (Migrated from github.com) commented 2019-07-12 09:38:47 +00:00
Copy Link
Copy Source

Haha, good catch. :)

Haha, good catch. :) ```suggestion ```
bumi (Migrated from github.com) reviewed 2019-07-12 09:48:50 +00:00
bumi (Migrated from github.com) left a comment
Copy Link
Copy Source

this is super cool!

this is super cool!
app/templates/dashboard/contributors/show.hbs
@@ -0,0 +28,4 @@
<p>
<a href="https://rinkeby.etherscan.io/address/{{model.account}}" class="button small" target="_blank" rel="noopener">Inspect Ethereum transactions</a>
{{#if model.ipfsHash}}
<a href="https://ipfs.io/ipfs/{{model.ipfsHash}}" class="button small" target="_blank" rel="noopener">Inspect IPFS profile</a>
bumi (Migrated from github.com) commented 2019-07-12 09:46:44 +00:00
Copy Link
Copy Source

we could use the gatewayUrl here

we could use the `gatewayUrl` here
raucao (Migrated from github.com) reviewed 2019-07-12 09:53:04 +00:00
app/templates/dashboard/contributors/show.hbs
@@ -0,0 +28,4 @@
<p>
<a href="https://rinkeby.etherscan.io/address/{{model.account}}" class="button small" target="_blank" rel="noopener">Inspect Ethereum transactions</a>
{{#if model.ipfsHash}}
<a href="https://ipfs.io/ipfs/{{model.ipfsHash}}" class="button small" target="_blank" rel="noopener">Inspect IPFS profile</a>
raucao (Migrated from github.com) commented 2019-07-12 09:53:04 +00:00
Copy Link
Copy Source

That was actually intentional, for two reasons:

  1. Have it be an independent source
  2. Have stuff be cached on ipfs.io so more nodes can distribute it
That was actually intentional, for two reasons: 1. Have it be an independent source 2. Have stuff be cached on ipfs.io so more nodes can distribute it
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#135
Delete Branch "feature/contributor_profiles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?