kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Use ember-auto-import instead of ember-browserify #138

Merged
galfert merged 3 commits from feature/use_ember_auto_import into master 2019-07-15 16:54:56 +00:00
Conversation 6 Commits 3 Files Changed 7
+1929 -674
galfert commented 2019-07-15 15:34:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

After some harsh fighting with npm and its unhelpful error messages, I finally managed to replace ember-browserify with ember-auto-import.

It required some custom Webpack config that inlines the JSON files in the kosmos-schemas dependency, instead of loading it via readFileSync.

After that, all other (seemingly) unrelated errors went away as well.

After some harsh fighting with npm and its unhelpful error messages, I finally managed to replace ember-browserify with ember-auto-import. It required some custom Webpack config that inlines the JSON files in the `kosmos-schemas` dependency, instead of loading it via `readFileSync`. After that, all other (seemingly) unrelated errors went away as well.
🎉 1
galfert commented 2019-07-15 15:40:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Damn, Travis still has build errors.

I actually deleted my node_modules directory and did a fresh install without problems.

Does anybody else get any errors?

Damn, Travis still has build errors. I actually deleted my `node_modules` directory and did a fresh install without problems. Does anybody else get any errors?
fsmanuel (Migrated from github.com) reviewed 2019-07-15 15:55:47 +00:00
package.json
@@ -61,7 +62,9 @@
"kosmos-schemas": "^2.0.0",
fsmanuel (Migrated from github.com) commented 2019-07-15 15:55:47 +00:00
Copy Link
Copy Source

They use a frok: https://github.com/ipfs/js-ipfs-http-client/blob/master/package.json#L67

They use a frok: https://github.com/ipfs/js-ipfs-http-client/blob/master/package.json#L67
galfert (Migrated from github.com) reviewed 2019-07-15 15:58:34 +00:00
package.json
@@ -61,7 +62,9 @@
"kosmos-schemas": "^2.0.0",
galfert (Migrated from github.com) commented 2019-07-15 15:58:33 +00:00
Copy Link
Copy Source

Any idea why I have to add the package at all when it's a dependency of a dependency?
I didn't have any error about it locally, but Travis did.

Any idea why I have to add the package at all when it's a dependency of a dependency? I didn't have any error about it locally, but Travis did.
fsmanuel (Migrated from github.com) reviewed 2019-07-15 16:36:31 +00:00
package.json
@@ -61,7 +62,9 @@
"kosmos-schemas": "^2.0.0",
fsmanuel (Migrated from github.com) commented 2019-07-15 16:36:31 +00:00
Copy Link
Copy Source

No. But the kredits-contracts dependencies are a mess. All kind of forks and beta releases... The blockchain community has to learn a lot about npm dependencies...

No. But the `kredits-contracts` dependencies are a mess. All kind of forks and beta releases... The blockchain community has to learn a lot about npm dependencies...
raucao (Migrated from github.com) reviewed 2019-07-15 16:45:40 +00:00
package.json
@@ -61,7 +62,9 @@
"kosmos-schemas": "^2.0.0",
raucao (Migrated from github.com) commented 2019-07-15 16:45:40 +00:00
Copy Link
Copy Source

Aragon npm deps:

fail-imminent

Aragon npm deps: ![fail-imminent](https://user-images.githubusercontent.com/842/61233221-56521700-a730-11e9-9233-fcba4703ec5a.jpg)
raucao commented 2019-07-15 16:54:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Hooray, all warnings gone!

Hooray, all warnings gone!
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
fsmanuel
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#138
Delete Branch "feature/use_ember_auto_import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?