kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Contribution details #140

Merged
raucao merged 3 commits from feature/contribution_details into master 2019-07-17 15:23:15 +00:00
Conversation 4 Commits 3 Files Changed 17
+5654 -1140
raucao commented 2019-07-17 11:01:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Adds a details pane for contribution records, similar to contributor profiles.

Just the basic details for now. Can be extended with all kinds of data, links, icons, etc. from here on.

Screenshot from 2019-07-17 12-58-06

closes #121

Adds a details pane for contribution records, similar to contributor profiles. Just the basic details for now. Can be extended with all kinds of data, links, icons, etc. from here on. ![Screenshot from 2019-07-17 12-58-06](https://user-images.githubusercontent.com/842/61371106-46ebde80-a894-11e9-837d-cfd6d07155bc.png) closes #121
galfert commented 2019-07-17 14:49:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Code looks alright and everything works.

One thing I noticed though: when scrolling down and selecting a contribution further down, you can't see the contribution details, because those are still at the top of the page.

Wouldn't it be better to show the contribution details right below the selected contribution?

Code looks alright and everything works. One thing I noticed though: when scrolling down and selecting a contribution further down, you can't see the contribution details, because those are still at the top of the page. Wouldn't it be better to show the contribution details right below the selected contribution?
raucao commented 2019-07-17 14:53:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Wouldn't it be better to show the contribution details right below the selected contribution?

No. The solution is to have the details pane be fixed in position when scrolling down, but that's a major layout problem, which I wasn't able to solve quickly. This is just the basic implementation for contributions details, as described above. All improvements from here on are separate PRs (and btw, anyone can help with them).

> Wouldn't it be better to show the contribution details right below the selected contribution? No. The solution is to have the details pane be fixed in position when scrolling down, but that's a major layout problem, which I wasn't able to solve quickly. This is just the basic implementation for contributions details, as described above. All improvements from here on are separate PRs (and btw, anyone can help with them).
raucao (Migrated from github.com) reviewed 2019-07-17 14:54:53 +00:00
app/styles/components/_contribution-details.scss
@@ -0,0 +1,59 @@
section#contribution-details {
raucao (Migrated from github.com) commented 2019-07-17 14:54:52 +00:00
Copy Link
Copy Source
```suggestion ```
galfert commented 2019-07-17 15:23:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

👍

👍
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#140
Delete Branch "feature/contribution_details"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?