kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Sign up via GitHub #142

Merged
raucao merged 14 commits from feature/signup into master 2019-08-29 10:52:04 +00:00
Conversation 7 Commits 14 Files Changed 28
+595 -15
raucao commented 2019-07-21 15:57:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

As discussed, only adding routes and UI for the signup flow.

Also contains a drive-by fix for a small bug with the account name, after extracting it to a component. See commits for more info.

As discussed, only adding routes and UI for the signup flow. Also contains a drive-by fix for a small bug with the account name, after extracting it to a component. See commits for more info.
galfert commented 2019-07-26 02:49:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Wired everything up to work with 67P/hubot-kredits#41.

I think the only thing missing is showing a success message or transitioning to a success page after the contributor has been created (see https://github.com/67P/kredits-web/pull/142/files#diff-9f12217253bedb83186b9295ac7b61d2R46).

Wired everything up to work with 67P/hubot-kredits#41. I think the only thing missing is showing a success message or transitioning to a success page after the contributor has been created (see https://github.com/67P/kredits-web/pull/142/files#diff-9f12217253bedb83186b9295ac7b61d2R46).
raucao (Migrated from github.com) reviewed 2019-07-26 10:44:46 +00:00
raucao (Migrated from github.com) left a comment
Copy Link
Copy Source

LGTM 👍

Just one question.

LGTM :+1: Just one question.
config/environment.js
@@ -37,6 +37,9 @@ module.exports = function(environment) {
raucao (Migrated from github.com) commented 2019-07-26 10:42:12 +00:00
Copy Link
Copy Source

Why is this using a port number? This should actually fail, as the HTTPS nginx sites are not listening on those ports.

https://gitea.kosmos.org/kosmos/chef/src/branch/master/site-cookbooks/kosmos-hubot/templates/default/nginx_conf_hubot.erb#L10

Why is this using a port number? This should actually fail, as the HTTPS nginx sites are not listening on those ports. https://gitea.kosmos.org/kosmos/chef/src/branch/master/site-cookbooks/kosmos-hubot/templates/default/nginx_conf_hubot.erb#L10
galfert (Migrated from github.com) reviewed 2019-07-26 17:04:27 +00:00
config/environment.js
@@ -37,6 +37,9 @@ module.exports = function(environment) {
galfert (Migrated from github.com) commented 2019-07-26 17:04:27 +00:00
Copy Link
Copy Source

Oh, yes. I didn't know the actual URL, so I searched the chef repo and found this: https://gitea.kosmos.org/kosmos/chef/src/branch/master/site-cookbooks/kosmos-hubot/attributes/default.rb#L6-L7

It's fixed now.

Oh, yes. I didn't know the actual URL, so I searched the chef repo and found this: https://gitea.kosmos.org/kosmos/chef/src/branch/master/site-cookbooks/kosmos-hubot/attributes/default.rb#L6-L7 It's fixed now.
raucao commented 2019-08-28 13:22:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

As long as I haven't missed anything, I think this is good to merge.

Anyone wants to confirm? Kredits label OK?

As long as I haven't missed anything, I think this is good to merge. Anyone wants to confirm? Kredits label OK?
galfert commented 2019-08-28 13:43:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Yes, I think all is good.

Yes, I think all is good.
raucao commented 2019-08-28 14:17:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Where does the sudden merge conflict come from? 🤔

Where does the sudden merge conflict come from? :thinking:
galfert commented 2019-08-28 15:25:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

No idea. Haven't edited any CSS in a long time.

No idea. Haven't edited any CSS in a long time.
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#142
Delete Branch "feature/signup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?