kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Improve sizing of entire layout #151

Merged
raucao merged 1 commits from feature/layout_sizing into master 2019-09-03 11:40:39 +00:00
Conversation 6 Commits 1 Files Changed 5
+8 -19
raucao commented 2019-09-01 16:10:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Due to me having designed this on a higher-res but not double-res display, everything turned out to be ridiculously large on a normal screen. This PR changes the layout to be a more reasonable size and drive-by fixes some CSS on the way.

Due to me having designed this on a higher-res but not double-res display, everything turned out to be ridiculously large on a normal screen. This PR changes the layout to be a more reasonable size and drive-by fixes some CSS on the way.
bumi (Migrated from github.com) reviewed 2019-09-01 16:10:16 +00:00
fsmanuel (Migrated from github.com) reviewed 2019-09-01 16:10:16 +00:00
galfert (Migrated from github.com) approved these changes 2019-09-03 11:34:04 +00:00
galfert (Migrated from github.com) left a comment
Copy Link
Copy Source

I only have retina and 4K screens. But on those everything looks alright. 👍

I only have retina and 4K screens. But on those everything looks alright. 👍
raucao commented 2019-09-03 11:40:35 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Great, thanks.

Great, thanks.
bumi commented 2019-09-03 12:16:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

👍 looks good on my machine.
but now the font should not be thinner

:+1: looks good on my machine. but now the font should not be thinner
raucao commented 2019-09-03 12:23:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

but now the font should not be thinner

Not be thinner than what?

> but now the font should not be thinner Not be thinner than what?
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
bumi
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#151
Delete Branch "feature/layout_sizing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?