kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Remove redundant pending status from contribution-status helper #160

Merged
galfert merged 2 commits from bugfix/remove_redundant_pending_status into master 2019-11-15 15:59:50 +00:00
Conversation 3 Commits 2 Files Changed 4
+22 -44
galfert commented 2019-11-15 15:29:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I noticed that every contribution had a "pending" status and found a line in the helper code that was probably just for testing purposes.

I then wondered why this wasn't caught by the helper test and found that the filename was missing the "-test" suffix, so the test wasn't included in the test suite.

I noticed that every contribution had a "pending" status and found a line in the helper code that was probably just for testing purposes. I then wondered why this wasn't caught by the helper test and found that the filename was missing the "-test" suffix, so the test wasn't included in the test suite.
raucao (Migrated from github.com) reviewed 2019-11-15 15:29:07 +00:00
fsmanuel (Migrated from github.com) reviewed 2019-11-15 15:29:07 +00:00
raucao commented 2019-11-15 15:59:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

thumbs_up_waynes_world

![thumbs_up_waynes_world](https://user-images.githubusercontent.com/842/68955681-d19f0480-07c6-11ea-8526-d1f1cbe0d813.gif)
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#160
Delete Branch "bugfix/remove_redundant_pending_status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?