kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Show contributor/contribution details on mobile #167

Closed
galfert wants to merge 2 commits from feature/163-small_screen_details into master
pull from: feature/163-small_screen_details
merge into: kredits:master
Conversation 5 Commits 2 Files Changed 6
+128 -49
galfert commented 2019-11-28 16:15:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Refs #163

On small screens, when selecting a contribution or contributor, the lists are hidden and only the details are shown. The transitions are animated using liquid-fire.

Refs #163 On small screens, when selecting a contribution or contributor, the lists are hidden and only the details are shown. The transitions are animated using liquid-fire.
raucao (Migrated from github.com) reviewed 2019-11-28 16:15:25 +00:00
galfert commented 2019-11-28 17:43:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'm wondering if we should also hide the welcome message when not signed in and showing details. Opinions?

kredits_web
I'm wondering if we should also hide the welcome message when not signed in and showing details. Opinions? <img width="328" alt="kredits_web" src="https://user-images.githubusercontent.com/843/69825206-c27c7580-120e-11ea-8c75-e347ecad5b1b.png">
raucao commented 2019-11-28 18:14:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I'm wondering if we should also hide the welcome message when not signed in and showing details. Opinions?

Yes, definitely.

> I'm wondering if we should also hide the welcome message when not signed in and showing details. Opinions? Yes, definitely.
galfert commented 2019-11-28 21:01:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Done.

Done.
galfert commented 2019-11-29 17:14:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Replaced by #169. I removed the transition anymations using liquid-fire, as they were not really working out here.

Replaced by #169. I removed the transition anymations using liquid-fire, as they were not really working out here.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#167
Delete Branch "feature/163-small_screen_details"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?