kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Update to kredits-contracts 6.0 and ethers 5.x #194

Closed
bumi wants to merge 1 commits from chore/kredits-contracts-6 into master
pull from: chore/kredits-contracts-6
merge into: kredits:master
Conversation 2 Commits 1 Files Changed 2
+1656 -551
bumi commented 2020-07-30 15:43:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Using the latest kredits-contracts and ethers.js libraries.

Using the latest kredits-contracts and ethers.js libraries.
bumi commented 2020-07-30 15:48:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Do we have any known issues with the handleTransfer callback?
on master I get a "Cannot read property 'decrementProperty' of undefined"
and in this PR the toNumber causes an overflow.
https://github.com/67P/kredits-web/blob/e047cc45ba4d1b8a6ef3518cd9350524e16ed19f/app/services/kredits.js#L485-L494

Do we have any known issues with the `handleTransfer` callback? on master I get a "Cannot read property 'decrementProperty' of undefined" and in this PR the `toNumber` causes an overflow. https://github.com/67P/kredits-web/blob/e047cc45ba4d1b8a6ef3518cd9350524e16ed19f/app/services/kredits.js#L485-L494
raucao commented 2020-07-30 16:00:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I don't know the issue from before, but it may well have been there.

I don't know the issue from before, but it may well have been there.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#194
Delete Branch "chore/kredits-contracts-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?