kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Fix for new Contribution#totalKreditsEarned type #201

Merged
bumi merged 2 commits from update-for-new-amounts into master 2022-10-06 10:26:09 +00:00
Conversation 2 Commits 2 Files Changed 1
+1 -2
bumi commented 2022-10-06 08:52:51 +00:00 (Migrated from github.com)
Copy Link
Copy Source

totalKreditsEarned is no longer a Big number but now already a number. I think this is due to the change of the denomination.

(not sure if we need this somewhere else, but it seemed OK)

totalKreditsEarned is no longer a Big number but now already a number. I think this is due to the change of the denomination. (not sure if we need this somewhere else, but it seemed OK)
raucao (Migrated from github.com) requested changes 2022-10-06 08:58:38 +00:00
app/services/kredits.js
raucao (Migrated from github.com) commented 2022-10-06 08:58:33 +00:00
Copy Link
Copy Source

This seems like a leftover from debugging?

This seems like a leftover from debugging?
raucao (Migrated from github.com) approved these changes 2022-10-06 10:25:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#201
Delete Branch "update-for-new-amounts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?