kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Improve caching, fix Firefox private mode usage #205

Merged
raucao merged 4 commits from feature/improve_caching into master 2022-11-14 14:48:33 +00:00
Conversation 1 Commits 4 Files Changed 4
+35 -19
raucao commented 2022-11-11 16:05:23 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I ran into quota exceeded errors in Firefox in private mode, which this PR fixes by not storing the extended details in the browser cache. Also, it was unnecessary to keep that data in memory in the first place. (We're not currently using any of the details in the UI, and we can easily re-fetch them from IPFS later).

Includes some other caching and event listening improvements. See commits.

I ran into quota exceeded errors in Firefox in private mode, which this PR fixes by not storing the extended details in the browser cache. Also, it was unnecessary to keep that data in memory in the first place. (We're not currently using any of the details in the UI, and we can easily re-fetch them from IPFS later). Includes some other caching and event listening improvements. See commits.
bumi commented 2022-11-14 15:03:18 +00:00 (Migrated from github.com)
Copy Link
Copy Source

🚀

🚀
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#205
Delete Branch "feature/improve_caching"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?