kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Pause app boot until window load event fired #21

Merged
galfert merged 2 commits from feature/wait_for_web3 into master 2017-06-13 12:37:20 +00:00
Conversation 6 Commits 2 Files Changed 2
+26
galfert commented 2017-06-13 11:14:57 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Closes #17

Allows the user provided Web3 instance to be inserted before we try to use it.

Closes #17 Allows the user provided Web3 instance to be inserted before we try to use it.
raucao commented 2017-06-13 11:18:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Should this really be called web3, when it's a generic one waiting for the DOM to load?

Should this really be called `web3`, when it's a generic one waiting for the DOM to load?
galfert commented 2017-06-13 11:25:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Should this really be called web3, when it's a generic one waiting for the DOM to load?

I wasn't sure about that either. Do you have a better suggestion?

> Should this really be called web3, when it's a generic one waiting for the DOM to load? I wasn't sure about that either. Do you have a better suggestion?
raucao commented 2017-06-13 11:30:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

defer-loading?

`defer-loading`?
galfert commented 2017-06-13 11:40:38 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Ok, I renamed it.

Ok, I renamed it.
bumi commented 2017-06-13 12:21:53 +00:00 (Migrated from github.com)
Copy Link
Copy Source

whoot awesome! will test it.

whoot awesome! will test it.
raucao commented 2017-06-13 12:33:54 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Now it works reliably. See commit description and/or IRC. ;)

Now it works reliably. See commit description and/or IRC. ;)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#21
Delete Branch "feature/wait_for_web3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?