Use ethers.js instead of the old web3 #29

2018-04-03T16:23:53Z

bumi commented

2018-04-03 16:23:53 +00:00

(Migrated from github.com)

the web3 we are using is old and everything will change with web3 1.0
which is currently in beta for ages.
ethers.js seems to be a bit more lightweight and implements pretty much
the same API so let's give it a try.

the web3 we are using is old and everything will change with web3 1.0 which is currently in beta for ages. ethers.js seems to be a bit more lightweight and implements pretty much the same API so let's give it a try.

raucao (Migrated from github.com) reviewed 2018-04-04 11:17:32 +00:00

tests/unit/controllers/index-test.js

						
				@@ -32,1 +34,4 @@

				  let controller = this.subject({

				    init: function() { }

				  });

				  addFixtures(controller);

raucao (Migrated from github.com) commented

2018-04-04 11:17:32 +00:00

I think a cleaner way would be to abstract adding the contract handlers into its own function, and then just overwrite that one in the test. That would make it easier to reason with in both the controller as well as the test.

fsmanuel (Migrated from github.com) approved these changes 2018-04-04 12:06:47 +00:00

app/services/kredits.js

						
				@@ -44,2 +31,3 @@

				  web3Provided: false, // Web3 provided (using Mist Browser, Metamask et al.)

				  ethProvider: null,

				  currentUserAccounts: null, // default to not having an account. this is the wen web3 is loaded.

fsmanuel (Migrated from github.com) commented

2018-04-04 10:59:28 +00:00

❤️

fsmanuel (Migrated from github.com) reviewed 2018-04-04 12:06:59 +00:00

tests/unit/controllers/index-test.js

						
				@@ -32,1 +34,4 @@

				  let controller = this.subject({

				    init: function() { }

				  });

				  addFixtures(controller);

fsmanuel (Migrated from github.com) commented

2018-04-04 12:06:59 +00:00

Good idea! We'll do that in a follow up PR.

fsmanuel commented

2018-04-04 12:21:06 +00:00

(Migrated from github.com)

🎉

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#29