kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Add account badge #31

Merged
bumi merged 4 commits from feature/account-badge into master 2018-04-06 15:54:54 +00:00
Conversation 3 Commits 4 Files Changed 2
+51 -11
bumi commented 2018-04-06 14:48:47 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This gives easy access to test if the "user/visitor" has an account, is i
a contributor and if she is core.

Right now I am using this to display an account badge the the name and the account. - currently not styled.

This gives easy access to test if the "user/visitor" has an account, is i a contributor and if she is core. Right now I am using this to display an account badge the the name and the account. - currently not styled.
fsmanuel (Migrated from github.com) requested changes 2018-04-06 15:19:23 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link
Copy Source

❤️ left some comments

❤️ left some comments
app/services/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-06 15:10:34 +00:00
Copy Link
Copy Source

You can add:
import { isEmpty, isPresent } from 'ember-utils';
and make this return isPresent(this.get('currentUser'));

You can add: `import { isEmpty, isPresent } from 'ember-utils';` and make this `return isPresent(this.get('currentUser'));`
fsmanuel (Migrated from github.com) commented 2018-04-06 15:10:48 +00:00
Copy Link
Copy Source

^^

^^
fsmanuel (Migrated from github.com) commented 2018-04-06 15:10:56 +00:00
Copy Link
Copy Source

^^

^^
app/services/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-06 15:12:55 +00:00
Copy Link
Copy Source

👍

👍
app/services/kredits.js
fsmanuel (Migrated from github.com) commented 2018-04-06 15:13:58 +00:00
Copy Link
Copy Source

We import RSVP so you can use it without Ember

We import `RSVP` so you can use it without `Ember`
fsmanuel (Migrated from github.com) commented 2018-04-06 15:14:07 +00:00
Copy Link
Copy Source

^^

^^
fsmanuel (Migrated from github.com) commented 2018-04-06 15:14:48 +00:00
Copy Link
Copy Source

let address = this.get('currentUserAccounts.firstObject')

`let address = this.get('currentUserAccounts.firstObject')`
fsmanuel (Migrated from github.com) commented 2018-04-06 15:15:15 +00:00
Copy Link
Copy Source

id = id.toNumber()

`id = id.toNumber()`
fsmanuel (Migrated from github.com) commented 2018-04-06 15:15:42 +00:00
Copy Link
Copy Source

if (id === 0)

`if (id === 0)`
app/templates/index.hbs
@@ -1,8 +1,19 @@
{{#if kredits.hasAccounts }}
fsmanuel (Migrated from github.com) commented 2018-04-06 15:18:33 +00:00
Copy Link
Copy Source

I would indent it like this:

{{#if kredits.hasAccounts }}
  <section id="user-account">
    {{!-- ... --}}
  </section>
{{/if}}
I would indent it like this: ```hbs {{#if kredits.hasAccounts }} <section id="user-account"> {{!-- ... --}} </section> {{/if}} ```
bumi commented 2018-04-06 15:41:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

guess this should get some styling before we merge it.

guess this should get some styling before we merge it.
fsmanuel (Migrated from github.com) approved these changes 2018-04-06 15:54:45 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link
Copy Source

👏

👏
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#31
Delete Branch "feature/account-badge"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?