kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Refactor getContributorById to be move generic #37

Merged
fsmanuel merged 2 commits from refactor/get-contributor-by-id into master 2018-04-07 23:32:46 +00:00
Conversation 2 Commits 2 Files Changed 1
+32 -31
fsmanuel commented 2018-04-07 22:55:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

We can use this generic functions also for the upcomig proposal refactoring.

We can use this generic functions also for the upcomig proposal refactoring.
bumi (Migrated from github.com) approved these changes 2018-04-07 23:07:23 +00:00
app/services/kredits.js
@@ -149,11 +144,12 @@ export default Service.extend({
getContributors() {
bumi (Migrated from github.com) commented 2018-04-07 23:05:38 +00:00
Copy Link
Copy Source

was wondering about the naming here... as it is more like building the ipfs hash - but then it is also replacing the "ipfsHash" attribute.

was wondering about the naming here... as it is more like building the ipfs hash - but then it is also replacing the "ipfsHash" attribute.
bumi (Migrated from github.com) commented 2018-04-07 23:06:31 +00:00
Copy Link
Copy Source

as ipfsHash gets replaced here, should the hashFunction and hashSize be removed from the data, those only work with the hex value that we replace

as ipfsHash gets replaced here, should the hashFunction and hashSize be removed from the data, those only work with the hex value that we replace
fsmanuel (Migrated from github.com) reviewed 2018-04-07 23:19:08 +00:00
app/services/kredits.js
@@ -149,11 +144,12 @@ export default Service.extend({
getContributors() {
fsmanuel (Migrated from github.com) commented 2018-04-07 23:19:08 +00:00
Copy Link
Copy Source

Good point. I was just ignoring them here:
https://github.com/67P/kredits-web/pull/37/files#diff-13940afb5bb6bef4e0cd9dfe4dcecb7cR123
Not sure what's the beste. But as you pointed out they are useless after that step. I'll remove them.

Good point. I was just ignoring them here: https://github.com/67P/kredits-web/pull/37/files#diff-13940afb5bb6bef4e0cd9dfe4dcecb7cR123 Not sure what's the beste. But as you pointed out they are useless after that step. I'll remove them.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#37
Delete Branch "refactor/get-contributor-by-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?