kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Refactor contract interaction in its own module #42

Merged
bumi merged 11 commits from kredits-module into master 2018-04-10 13:46:58 +00:00
Conversation 3 Commits 11 Files Changed 25
+379 -377
bumi commented 2018-04-09 17:31:16 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This moves most of the contract interaction into a Kredits wrapper module that makes it easy to interact with the contracts and does all the hard work.

The module is still included here but will be moved into its own npm package (kredits-contracts (=truffle-kredits))

This moves most of the contract interaction into a Kredits wrapper module that makes it easy to interact with the contracts and does all the hard work. The module is still included here but will be moved into its own npm package (kredits-contracts (=truffle-kredits))
bumi commented 2018-04-09 18:43:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

ok, this PR is getting quite big and it is time to merge. @travis-ci, what do you think?

ok, this PR is getting quite big and it is time to merge. @travis-ci, what do you think?
fsmanuel (Migrated from github.com) approved these changes 2018-04-10 12:36:43 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link
Copy Source

Left some comments where we can improve the code but already approved because we can also do that later.

Left some comments where we can improve the code but already approved because we can also do that later.
app/components/add-proposal/component.js
@@ -55,3 +55,3 @@
window.scroll(0,0);
window.alert('Contributor added.');
window.alert('Proposal added.');
});
fsmanuel (Migrated from github.com) commented 2018-04-10 12:09:39 +00:00
Copy Link
Copy Source

Good catch!

Good catch!
app/controllers/index.js
fsmanuel (Migrated from github.com) commented 2018-04-10 12:11:53 +00:00
Copy Link
Copy Source

No need for .toString()

No need for `.toString()`
app/lib/kredits/contracts/contributor.js
@@ -0,0 +1,61 @@
import ethers from 'npm:ethers';
fsmanuel (Migrated from github.com) commented 2018-04-10 12:17:14 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
fsmanuel (Migrated from github.com) commented 2018-04-10 12:17:20 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
fsmanuel (Migrated from github.com) commented 2018-04-10 12:18:09 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
app/lib/kredits/contracts/operator.js
@@ -0,0 +1,61 @@
import ethers from 'npm:ethers';
fsmanuel (Migrated from github.com) commented 2018-04-10 12:18:33 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
fsmanuel (Migrated from github.com) commented 2018-04-10 12:18:40 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
fsmanuel (Migrated from github.com) commented 2018-04-10 12:18:55 +00:00
Copy Link
Copy Source

We can use this.functions

We can use `this.functions`
app/lib/kredits/utils/ipfs.js
@@ -0,0 +1,55 @@
import ipfsAPI from 'npm:ipfs-api';
fsmanuel (Migrated from github.com) commented 2018-04-10 12:28:40 +00:00
Copy Link
Copy Source

Should we call it deserialize because it's the function and not the deserializer?

Should we call it `deserialize` because it's the function and not the deserializer?
app/lib/kredits/utils/ipfs.js
@@ -0,0 +28,4 @@
});
}
cat(hashData) {
fsmanuel (Migrated from github.com) commented 2018-04-10 12:30:55 +00:00
Copy Link
Copy Source

❤️

❤️
bumi (Migrated from github.com) reviewed 2018-04-10 13:24:30 +00:00
app/lib/kredits/utils/ipfs.js
@@ -0,0 +1,55 @@
import ipfsAPI from 'npm:ipfs-api';
bumi (Migrated from github.com) commented 2018-04-10 13:24:30 +00:00
Copy Link
Copy Source

good point here.
actually wanted to ask you. I felt it is nicer to pass a function here than an object. what do you think?

good point here. actually wanted to ask you. I felt it is nicer to pass a function here than an object. what do you think?
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
bumi
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#42
Delete Branch "kredits-module"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?