Adjust for new naming conventions #45
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: kredits/kredits-web#45
Reference in New Issue
Block a user
related: https://github.com/67P/truffle-kredits/pull/24
@@ -15,3 +15,3 @@<ul><li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li><li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>{{#if contributor.ipfsHash}}I don't fully understand why the address is called account now, because didn't we allow to change an address, specifically so that it is not the same as an account?
@@ -15,3 +15,3 @@<ul><li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li><li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>{{#if contributor.ipfsHash}}the change of an address is still supported (see the contracts)
the word
addressis reserved in solidity - it is the type. that's why we named the attributeaccountin the contract. To be consistent with the smart contract I changed it in the frontend also to to account and I think we should always use the word account.@@ -15,3 +15,3 @@<ul><li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li><li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>{{#if contributor.ipfsHash}}Ah ok. I find it a bit misleading as a term for a single property of an account/person, but better that it's the same on both sides for sure.
@@ -15,3 +15,3 @@<ul><li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li><li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>{{#if contributor.ipfsHash}}it is account because ethereum talks about accounts - and it is the ethereum account of that contributor. - but ethereumAccount is a bit long.
@@ -15,3 +15,3 @@<ul><li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li><li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>{{#if contributor.ipfsHash}}Makes sense.