kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Adjust for new naming conventions #45

Merged
bumi merged 1 commits from refactor/naming-conventions into master 2018-04-15 16:24:17 +00:00
Conversation 6 Commits 1 Files Changed 10
+15 -39
bumi commented 2018-04-10 16:47:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

related: https://github.com/67P/truffle-kredits/pull/24

related: https://github.com/67P/truffle-kredits/pull/24
fsmanuel (Migrated from github.com) reviewed 2018-04-10 16:47:14 +00:00
raucao (Migrated from github.com) reviewed 2018-04-10 17:09:09 +00:00
app/components/contributor-list/template.hbs
@@ -15,3 +15,3 @@
<ul>
<li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li>
<li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
{{#if contributor.ipfsHash}}
raucao (Migrated from github.com) commented 2018-04-10 17:09:09 +00:00
Copy Link
Copy Source

I don't fully understand why the address is called account now, because didn't we allow to change an address, specifically so that it is not the same as an account?

I don't fully understand why the address is called account now, because didn't we allow to change an address, specifically so that it is not the same as an account?
bumi (Migrated from github.com) reviewed 2018-04-10 17:13:19 +00:00
app/components/contributor-list/template.hbs
@@ -15,3 +15,3 @@
<ul>
<li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li>
<li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
{{#if contributor.ipfsHash}}
bumi (Migrated from github.com) commented 2018-04-10 17:13:19 +00:00
Copy Link
Copy Source

the change of an address is still supported (see the contracts)
the word address is reserved in solidity - it is the type. that's why we named the attribute account in the contract. To be consistent with the smart contract I changed it in the frontend also to to account and I think we should always use the word account.

the change of an address is still supported (see the contracts) the word `address` is reserved in solidity - it is the type. that's why we named the attribute `account` in the contract. To be consistent with the smart contract I changed it in the frontend also to to account and I think we should always use the word account.
raucao (Migrated from github.com) reviewed 2018-04-10 18:09:36 +00:00
app/components/contributor-list/template.hbs
@@ -15,3 +15,3 @@
<ul>
<li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li>
<li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
{{#if contributor.ipfsHash}}
raucao (Migrated from github.com) commented 2018-04-10 18:09:36 +00:00
Copy Link
Copy Source

Ah ok. I find it a bit misleading as a term for a single property of an account/person, but better that it's the same on both sides for sure.

Ah ok. I find it a bit misleading as a term for a single property of an account/person, but better that it's the same on both sides for sure.
bumi (Migrated from github.com) reviewed 2018-04-10 18:19:51 +00:00
app/components/contributor-list/template.hbs
@@ -15,3 +15,3 @@
<ul>
<li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li>
<li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
{{#if contributor.ipfsHash}}
bumi (Migrated from github.com) commented 2018-04-10 18:19:51 +00:00
Copy Link
Copy Source

it is account because ethereum talks about accounts - and it is the ethereum account of that contributor. - but ethereumAccount is a bit long.

it is account because ethereum talks about accounts - and it is the ethereum account of that contributor. - but ethereumAccount is a bit long.
raucao (Migrated from github.com) reviewed 2018-04-10 19:32:44 +00:00
app/components/contributor-list/template.hbs
@@ -15,3 +15,3 @@
<ul>
<li><a href="https://testnet.etherscan.io/address/{{contributor.address}}">Inspect Ethereum transactions</a></li>
<li><a href="https://testnet.etherscan.io/address/{{contributor.account}}">Inspect Ethereum transactions</a></li>
{{#if contributor.ipfsHash}}
raucao (Migrated from github.com) commented 2018-04-10 19:32:44 +00:00
Copy Link
Copy Source

Makes sense.

Makes sense.
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
bumi
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#45
Delete Branch "refactor/naming-conventions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?