kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

[WIP] Use infura hosted provider if web3 is not available #61

Closed
bumi wants to merge 2 commits from feature/infura-fallback-provider into master
pull from: feature/infura-fallback-provider
merge into: kredits:master
Conversation 3 Commits 2 Files Changed 2
+11 -14
bumi commented 2018-04-22 16:53:05 +00:00 (Migrated from github.com)
Copy Link
Copy Source

If the user does not have metamask or similar (no web3 provider is
availale) we will load data from the infura node.

No signer is available for the infura node but the ethers provider would
throw an error if we try to access it - so this moves the decision of
choosing the provider to the ethProvider function.

If the user does not have metamask or similar (no web3 provider is availale) we will load data from the infura node. No signer is available for the infura node but the ethers provider would throw an error if we try to access it - so this moves the decision of choosing the provider to the ethProvider function.
fsmanuel (Migrated from github.com) reviewed 2018-04-22 16:53:05 +00:00
bumi commented 2018-04-22 18:27:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

not sure if I like using the infura provider - at least not how this PR uses it - because that would make it impossible to run kredits-web WITHOUT metamask on a local network.

not sure if I like using the infura provider - at least not how this PR uses it - because that would make it impossible to run kredits-web WITHOUT metamask on a local network.
bumi commented 2018-06-14 15:00:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

we don't use the specific infura host but the general JSONRPC interface

we don't use the specific infura host but the general JSONRPC interface

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#61
Delete Branch "feature/infura-fallback-provider"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?