kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Improve layout, show contribution details #75

Merged
raucao merged 6 commits from feature/improve_layout into master 2018-06-22 20:27:00 +00:00
Conversation 8 Commits 6 Files Changed 10
+232 -103
raucao commented 2018-06-17 14:21:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I changed the whole layout, so one can see more things at once, and more importantly, all details for the actual contributions. This branch is currently deployed ton https://kredits.kosmos.org so you can check it out there as well.

screenshot-2018-6-17 kosmos kredits

screenshot from 2018-06-17 16-20-25

(Hint: In order to run the branch locally, you now only need to start your IPFS daemon. Everything else comes from the Internet.)

I changed the whole layout, so one can see more things at once, and more importantly, all details for the actual contributions. This branch is currently deployed ton https://kredits.kosmos.org so you can check it out there as well. ![screenshot-2018-6-17 kosmos kredits](https://user-images.githubusercontent.com/842/41508781-30e76ba8-724a-11e8-9ba7-26fdd8e2be05.jpg) ![screenshot from 2018-06-17 16-20-25](https://user-images.githubusercontent.com/842/41508796-60dd2384-724a-11e8-9644-352ce3570e95.png) _(Hint: In order to run the branch locally, you now only need to start your IPFS daemon. Everything else comes from the Internet.)_
fsmanuel (Migrated from github.com) approved these changes 2018-06-18 10:54:09 +00:00
fsmanuel (Migrated from github.com) left a comment
Copy Link
Copy Source

Only one small change.
I would suggest to move "Add Contributor" below the "Contributors" list but that is not blocking.

Only one small change. I would suggest to move "Add Contributor" below the "Contributors" list but that is not blocking.
app/templates/application.hbs
@@ -4,0 +5,4 @@
{{#if kredits.hasAccounts }}
{{#if kredits.currentUser}}
{{kredits.currentUser.name}}
{{#if kredits.currentUserIsCore}}(core){{/if}}
fsmanuel (Migrated from github.com) commented 2018-06-18 10:50:13 +00:00
Copy Link
Copy Source

Can we make it

{{#if (and kredits.hasAccounts kredits.currentUser}}
{{else}
Can we make it ```hbs {{#if (and kredits.hasAccounts kredits.currentUser}} {{else} ```
raucao (Migrated from github.com) reviewed 2018-06-18 10:57:42 +00:00
app/templates/application.hbs
@@ -4,0 +5,4 @@
{{#if kredits.hasAccounts }}
{{#if kredits.currentUser}}
{{kredits.currentUser.name}}
{{#if kredits.currentUserIsCore}}(core){{/if}}
raucao (Migrated from github.com) commented 2018-06-18 10:57:42 +00:00
Copy Link
Copy Source

Sounds to me like that should be a single computed property.

Sounds to me like that should be a single computed property.
raucao commented 2018-06-18 10:58:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I would suggest to move "Add Contributor" below the "Contributors" list but that is not blocking.

I tried that first and it wasn't great. But there's #74 anyway, because this is not something that should be on the index in the first place.

> I would suggest to move "Add Contributor" below the "Contributors" list but that is not blocking. I tried that first and it wasn't great. But there's #74 anyway, because this is not something that should be on the index in the first place.
fsmanuel commented 2018-06-18 11:07:28 +00:00 (Migrated from github.com)
Copy Link
Copy Source

You are right! I was about to say that but figured the information that one should talk to a core memeber is valueable to get ppl. involved.

You are right! I was about to say that but figured the information that one should talk to a core memeber is valueable to get ppl. involved.
fsmanuel (Migrated from github.com) reviewed 2018-06-18 11:14:39 +00:00
app/templates/application.hbs
@@ -4,0 +5,4 @@
{{#if kredits.hasAccounts }}
{{#if kredits.currentUser}}
{{kredits.currentUser.name}}
{{#if kredits.currentUserIsCore}}(core){{/if}}
fsmanuel (Migrated from github.com) commented 2018-06-18 11:14:39 +00:00
Copy Link
Copy Source

As far as I understand the code we already handle hasAccounts in getCurrentUser:
https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L147-L162

As far as I understand the code we already handle `hasAccounts` in `getCurrentUser`: https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L147-L162
raucao commented 2018-06-18 11:15:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source

but figured the information that one should talk to a core memeber is valueable to get ppl. involved.

Completely agree! But that will have to be part of the general onboarding for anonymous users I think. Lots to improve there, because right now there's zero information for them.

> but figured the information that one should talk to a core memeber is valueable to get ppl. involved. Completely agree! But that will have to be part of the general onboarding for anonymous users I think. Lots to improve there, because right now there's zero information for them.
bumi commented 2018-06-22 13:00:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

why does that WIP bot say this one is still WIP? is it?
I think that's a great optimization to the current long list.
let's merge it.

why does that WIP bot say this one is still WIP? is it? I think that's a great optimization to the current long list. let's merge it.
raucao commented 2018-06-22 20:26:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I think the bot picked it up from a commit message. Thanks.

I think the bot picked it up from a commit message. Thanks.
Sign in to join this conversation.
Reviewers
No Reviewers
raucao
fsmanuel
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#75
Delete Branch "feature/improve_layout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?