kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Add doughnut chart for contribution composition #77

Merged
raucao merged 4 commits from feature/charts into master 2018-07-17 18:45:33 +00:00
Conversation 6 Commits 4 Files Changed 10
+303 -30
raucao commented 2018-07-15 10:00:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Enables contributors to see at a glance if all areas of a project are tended to.

screenshot from 2018-07-15 12-01-07

Enables contributors to see at a glance if all areas of a project are tended to. ![screenshot from 2018-07-15 12-01-07](https://user-images.githubusercontent.com/842/42732750-f460f4c2-8826-11e8-961d-dcf1d39b6d92.png)
bumi (Migrated from github.com) reviewed 2018-07-15 10:00:48 +00:00
fsmanuel (Migrated from github.com) reviewed 2018-07-15 10:00:48 +00:00
galfert (Migrated from github.com) approved these changes 2018-07-16 15:03:44 +00:00
galfert (Migrated from github.com) left a comment
Copy Link
Copy Source

Chart looks nice. Code looks good, too.

Just left a little improvement suggestion.

Chart looks nice. Code looks good, too. Just left a little improvement suggestion.
app/components/chart-contributions-by-type/component.js
@@ -0,0 +22,4 @@
kinds[c.kind] = kinds[c.kind] + c.amount
} else {
kinds[c.kind] = c.amount;
}
galfert (Migrated from github.com) commented 2018-07-16 15:02:47 +00:00
Copy Link
Copy Source

I think the if/else block can be simplified to kinds[c.kind] = (kinds[c.kind] || 0) + c.amount;.

I think the `if/else` block can be simplified to `kinds[c.kind] = (kinds[c.kind] || 0) + c.amount;`.
raucao (Migrated from github.com) reviewed 2018-07-16 15:12:53 +00:00
app/components/chart-contributions-by-type/component.js
@@ -0,0 +22,4 @@
kinds[c.kind] = kinds[c.kind] + c.amount
} else {
kinds[c.kind] = c.amount;
}
raucao (Migrated from github.com) commented 2018-07-16 15:12:53 +00:00
Copy Link
Copy Source

Ooh, that's a good idea!

Ooh, that's a good idea!
bumi commented 2018-07-17 18:34:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

magic ember! :)
looks good to me! pretty cool!

magic ember! :) looks good to me! pretty cool!
raucao commented 2018-07-17 18:45:27 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks, everyone.

Thanks, everyone.
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
fsmanuel
galfert
raucao
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#77
Delete Branch "feature/charts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?