Add doughnut chart for contribution composition #77

2018-07-15T10:00:48Z

raucao commented

2018-07-15 10:00:48 +00:00

(Migrated from github.com)

Enables contributors to see at a glance if all areas of a project are tended to.

Enables contributors to see at a glance if all areas of a project are tended to. ![screenshot from 2018-07-15 12-01-07](https://user-images.githubusercontent.com/842/42732750-f460f4c2-8826-11e8-961d-dcf1d39b6d92.png)

bumi (Migrated from github.com) reviewed 2018-07-15 10:00:48 +00:00

fsmanuel (Migrated from github.com) reviewed 2018-07-15 10:00:48 +00:00

galfert (Migrated from github.com) approved these changes 2018-07-16 15:03:44 +00:00

galfert (Migrated from github.com) left a comment

Chart looks nice. Code looks good, too.

Just left a little improvement suggestion.

Chart looks nice. Code looks good, too. Just left a little improvement suggestion.

app/components/chart-contributions-by-type/component.js

						
				@@ -0,0 +22,4 @@

				                          kinds[c.kind] = kinds[c.kind] + c.amount

				                        } else {

				                          kinds[c.kind] = c.amount;

				                        }

galfert (Migrated from github.com) commented

2018-07-16 15:02:47 +00:00

I think the if/else block can be simplified to kinds[c.kind] = (kinds[c.kind] || 0) + c.amount;.

I think the `if/else` block can be simplified to `kinds[c.kind] = (kinds[c.kind] || 0) + c.amount;`.

raucao (Migrated from github.com) reviewed 2018-07-16 15:12:53 +00:00

app/components/chart-contributions-by-type/component.js

						
				@@ -0,0 +22,4 @@

				                          kinds[c.kind] = kinds[c.kind] + c.amount

				                        } else {

				                          kinds[c.kind] = c.amount;

				                        }

raucao (Migrated from github.com) commented

2018-07-16 15:12:53 +00:00

Ooh, that's a good idea!

bumi commented

2018-07-17 18:34:32 +00:00

(Migrated from github.com)

magic ember! :)
looks good to me! pretty cool!

magic ember! :) looks good to me! pretty cool!

raucao commented

2018-07-17 18:45:27 +00:00

(Migrated from github.com)

Thanks, everyone.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#77