kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

If user brings blockchain, make sure it's the right one #82

New Issue
Closed
opened 2018-10-28 11:02:08 +00:00 by raucao · 2 comments
raucao commented 2018-10-28 11:02:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Currently, with e.g. Metamask installed, and e.g. mainnet selected, the app will throw an exception about not being able to find the contract, but not tell the user anything about it. In that case, the loading indicator will just be visible indefinitely.

The app should catch that error and notify the user to make sure they have the right chain selected.

Currently, with e.g. Metamask installed, and e.g. mainnet selected, the app will throw an exception about not being able to find the contract, but not tell the user anything about it. In that case, the loading indicator will just be visible indefinitely. The app should catch that error and notify the user to make sure they have the right chain selected.
bumi commented 2019-07-22 08:18:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

We have the available_networks method in kredits-contracts (Kredits.available_networks()) that can be used.
After the window.ethereum.enable() call we should be able to check for window.ethereum.networkVersion which returns a string of the network ID (should be confirmed if that is metamask specific or a general provider standard). https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L121

maybe @haythem96 you want to have a look at this?

We have the [`available_networks`]( https://github.com/67P/kredits-contracts/blob/master/lib/kredits.js#L86) method in kredits-contracts (`Kredits.available_networks()`) that can be used. After the `window.ethereum.enable()` call we should be able to check for `window.ethereum.networkVersion` which returns a string of the network ID (should be confirmed if that is metamask specific or a general provider standard). https://github.com/67P/kredits-web/blob/master/app/services/kredits.js#L121 maybe @haythem96 you want to have a look at this?
👍 1
haythemsellami commented 2019-07-22 13:05:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@bumi sure will look at that...

@bumi sure will look at that...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#82
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?