kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Update Ember to version 3.8.0 #89

Merged
galfert merged 4 commits from feature/84-update_ember_3_8 into master 2019-03-29 12:03:56 +00:00
Conversation 4 Commits 4 Files Changed 30
+7593 -2198
galfert commented 2019-03-27 17:25:03 +00:00 (Migrated from github.com)
Copy Link
Copy Source

At the moment there is still a deprecation warning about ember-browserify left. There is no update for that library yet, and the maintainer recommends to switch to ember-auto-import instead. So far I couldn't get that to work with importing kredits-contracts though.

At the moment there is still a deprecation warning about ember-browserify left. There is no update for that library yet, and the maintainer recommends to switch to ember-auto-import instead. So far I couldn't get that to work with importing kredits-contracts though.
raucao commented 2019-03-28 14:19:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What's the WIP here actually?

What's the WIP here actually?
galfert commented 2019-03-28 19:35:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

What I wrote in the PR description. But it could also be done in a separate PR.

What I wrote in the PR description. But it could also be done in a separate PR.
raucao commented 2019-03-28 21:43:01 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Yeah, I think it can/should be a new one, because this seems to be functional on its own and already providing value by upgrading Ember to the latest version.

Yeah, I think it can/should be a new one, because this seems to be functional on its own and already providing value by upgrading Ember to the latest version.
galfert commented 2019-03-29 10:06:49 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Ok, I removed the WIP from the title

Ok, I removed the WIP from the title
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#89
Delete Branch "feature/84-update_ember_3_8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?