kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Remove default contributors value in propsal component #93

Merged
bumi merged 2 commits from fix/contributor-list-on-proposals into master 2019-04-03 17:02:06 +00:00
Conversation 4 Commits 2 Files Changed 1
+1 -3
bumi commented 2019-04-03 11:48:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

It seems that this somehow prevents/overwrites the contributors which actually should be loaded in the controller.

Before that the contributors dropdown on the proposals new page was empty. This change seems to fix it.

It seems that this somehow prevents/overwrites the contributors which actually should be loaded in the controller. Before that the contributors dropdown on the proposals new page was empty. This change seems to fix it.
galfert commented 2019-04-03 12:27:15 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I set the default to an empty array in a different way. Just to be sure nothing fails when you don't give any contributors attribute to the component.

I set the default to an empty array in a different way. Just to be sure nothing fails when you don't give any contributors attribute to the component.
bumi commented 2019-04-03 12:32:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

so what is the best way to fix that it is loaded from the controller (which is some alias of kredits.contirbutors) ?

so what is the best way to fix that it is loaded from the controller (which is some alias of kredits.contirbutors) ?
galfert commented 2019-04-03 12:35:22 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I don't understand the question. What's wrong with that? It is given as an attribute to the component here: https://github.com/67P/kredits-web/blob/3dbcba5eb2b1c70bef42e31528bc94b288595f3c/app/templates/proposals/new.hbs#L7

I don't understand the question. What's wrong with that? It is given as an attribute to the component here: https://github.com/67P/kredits-web/blob/3dbcba5eb2b1c70bef42e31528bc94b288595f3c/app/templates/proposals/new.hbs#L7
raucao commented 2019-04-03 12:37:17 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The component should always get a list anyway, because you cannot have a contribution without a contributor. So I think this solution is fine now.

The component should always get a list anyway, because you cannot have a contribution without a contributor. So I think this solution is fine now.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) haythem (haythem) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kredits/kredits-web#93
Delete Branch "fix/contributor-list-on-proposals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?