Support new Metamask/Web3 privacy mode #97

2019-04-04T10:14:30Z

raucao commented

2019-04-04 10:14:30 +00:00

(Migrated from github.com)

closes #87

bumi (Migrated from github.com) reviewed 2019-04-04 10:41:02 +00:00

app/services/kredits.js

						
				@@ -58,0 +50,4 @@

				        console.debug('[kredits] Using user-provided instance, e.g. from Mist browser or Metamask');

				        ethProvider = new ethers.providers.Web3Provider(web3.currentProvider);

				        ethProvider.listAccounts().then(accounts => {

				          context.set('currentUserAccounts', accounts);

bumi (Migrated from github.com) commented

2019-04-04 10:41:01 +00:00

do those functions need to be in that RSVP.Promise ?
or could those be general functions that return a Promise that resolves the ethProvider?

something like:

getEthProvider: function() {
  if (window.ethereum) {
    return window.ethereum.enable().then(() => {
      return instantiateWithAccount(...)
    })
  }
}

do those functions need to be in that RSVP.Promise ? or could those be general functions that return a Promise that resolves the ethProvider? something like: ```js getEthProvider: function() { if (window.ethereum) { return window.ethereum.enable().then(() => { return instantiateWithAccount(...) }) } } ```

raucao (Migrated from github.com) reviewed 2019-04-04 10:43:41 +00:00

app/services/kredits.js

						
				@@ -58,0 +50,4 @@

				        console.debug('[kredits] Using user-provided instance, e.g. from Mist browser or Metamask');

				        ethProvider = new ethers.providers.Web3Provider(web3.currentProvider);

				        ethProvider.listAccounts().then(accounts => {

				          context.set('currentUserAccounts', accounts);

raucao (Migrated from github.com) commented

2019-04-04 10:43:41 +00:00

It's easier this way. Anyone wanting to refactor it more can do so in the future. PRs welcome.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kredits/kredits-web#97