kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Display contribution balances not token balances #107

Merged
bumi merged 3 commits from feature/use-contribution-balances into master 2019-04-24 08:57:25 +00:00
Conversation 6 Commits 3 Files Changed 8
+1 -3
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit de937aceee - Show all commits
app/services/kredits.js
+1 -3
View File
1
 @@ -118,9 +118,7 @@ export default Service.extend({
totalKreditsEarned: computed(function() {
return this.kredits.Contribution.functions.totalKreditsEarned(true)
raucao commented 2019-04-23 11:07:32 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Not a fan of the unnamed true in this new function call, because the meaning is completely hidden, until one finds and reads the Solidity source code of it.

Not a fan of the unnamed `true` in this new function call, because the meaning is completely hidden, until one finds and reads the Solidity source code of it.
bumi commented 2019-04-23 11:50:12 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

yes, me neither. but it is a contract call and generated from the wrapper.
could at some write our own function in the wrapper class.

yes, me neither. but it is a contract call and generated from the wrapper. could at some write our own function in the wrapper class.
raucao commented 2019-04-23 12:00:03 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

Ah, yes.

Ah, yes.
.then(total => {
return total.toNumber();
});
.then(total => total.toNumber());
}),