kredits/kredits-web
9
0
Fork 0
Code Issues 23 Pull Requests 1 Actions Releases 18 Activity

Remove redundant pending status from contribution-status helper #160

Merged
galfert merged 2 commits from bugfix/remove_redundant_pending_status into master 2019-11-15 15:59:50 +00:00
Conversation 3 Commits 2 Files Changed 4
+22 -44
4 changed files with 22 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/helpers/contribution-status.js
-2
View File
@@ -25,8 +25,6 @@ export default Helper.extend({
status.push('pending'); status.push('pending');
} }
status.push('pending');
return status.join(' '); return status.join(' ');
}, },
tests/unit/helpers/contribution-status-test.js
+22
View File
@@ -0,0 +1,22 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
import Contribution from 'kredits-web/models/contribution';
module('Unit | Helper | contribution-status', function (hooks) {
setupTest(hooks);
test('returns the appropriate status', function (assert) {
const contributionStatus = this.owner.factoryFor('helper:contribution-status').create();
const kredits = this.owner.lookup('service:kredits');
kredits.set('currentBlock', 23000);
const contributionUnconfirmed = Contribution.create({ confirmedAt: 23001, vetoed: false });
const contributionConfirmed = Contribution.create({ confirmedAt: 21000, vetoed: false });
const contributionVetoed = Contribution.create({ confirmedAt: 23001, vetoed: true });
assert.equal(contributionStatus.compute([contributionUnconfirmed]), 'unconfirmed');
assert.equal(contributionStatus.compute([contributionConfirmed]), 'confirmed');
assert.equal(contributionStatus.compute([contributionVetoed]), 'vetoed');
});
});
tests/unit/helpers/contribution-status.js
-21
View File
@@ -1,21 +0,0 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Helper | contribution-status', function (hooks) {
setupTest(hooks);
test('returns the appropriate status', function (assert) {
const contributionStatus = this.owner.factoryFor('helper:contribution-status').create();
const kredits = this.owner.lookup('service:kredits');
kredits.set('currentBlock', 23000);
const contributionUnconfirmed = { confirmedAt: 23001, vetoed: false };
const contributionConfirmed = { confirmedAt: 21000, vetoed: false };
const contributionVetoed = { confirmedAt: 23001, vetoed: true };
assert.eq(contributionStatus.compute([contributionUnconfirmed]), 'unconfirmed');
assert.eq(contributionStatus.compute([contributionConfirmed]), 'confirmed');
assert.eq(contributionStatus.compute([contributionVetoed]), 'vetoed');
});
});
tests/unit/helpers/is-confirmed-contribution.js
-21
View File
@@ -1,21 +0,0 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
module('Unit | Helper | contribution-status', function (hooks) {
setupTest(hooks);
test('returns the appropriate status', function (assert) {
const contributionStatus = this.owner.factoryFor('helper:contribution-status').create();
const kredits = this.owner.lookup('service:kredits');
kredits.set('currentBlock', 23000);
const contributionUnconfirmed = { confirmedAt: 23001, vetoed: false };
const contributionConfirmed = { confirmedAt: 21000, vetoed: false };
const contributionVetoed = { confirmedAt: 23001, vetoed: true };
assert.notOk(contributionStatus.compute([contributionUnconfirmed]), 'unconfirmed');
assert.notOk(contributionStatus.compute([contributionVetoed]), 'vetoed');
assert.ok(contributionStatus.compute([contributionConfirmed]), 'confirmed');
});
});