kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Upgrade Ember and deps to 3.18/Octane #186

Merged
raucao merged 15 commits from chore/upgrade_ember_and_deps into master 2020-05-11 11:18:59 +00:00
Conversation 10 Commits 15 Files Changed 68
+7 -5
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3cc01cce4e - Show all commits
app/components/add-contributor/template.hbs
+5 -4
View File
@@ -1,10 +1,11 @@
<form onsubmit={{action "submit"}}>
galfert commented 2020-05-11 10:57:40 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

No @ for id, placeholder and class, but one should be added to value.

No `@` for `id`, `placeholder` and `class`, but one should be added to `value`.
<p>
<label for="c-account">Ethereum account</label>
<Input @name="account" @id="c-account"
@type="text" value={{this.account}}
@placeholder="0xF18E631Ea191aE4ebE70046Fcb01a436554421BA4"
@class={{if this.isValidAccount "valid" ""}} />
<Input @type="text"
@value={{this.account}}
name="account" id="c-account"
placeholder="0xF18E631Ea191aE4ebE70046Fcb01a436554421BA4"
class={{if this.isValidAccount "valid" ""}} />
</p>
<p>
<label for="c-kind">Kind</label>
app/templates/dashboard.hbs
+2 -1
View File
1
 @@ -36,7 +36,8 @@
<span class="number">{{this.contributorsWithKredits.length}}</span> contributors
</p>
<p class="stats">
<Input @type="checkbox" @id="hide-unnconfirmed-kredits"
<Input id="hide-unnconfirmed-kredits"
@type="checkbox"
@checked={{this.showUnconfirmedKredits}} />
<label for="hide-unnconfirmed-kredits">Show unconfirmed kredits in toplist</label>
</p>