kredits/kredits-web
9
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Releases 18 Activity

Improve reimbursement lists #222

Merged
raucao merged 8 commits from feature/reimbursement-lists into master 2024-03-20 13:50:33 +00:00
Conversation 3 Commits 8 Files Changed 8
+1 -2
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc044df9fd - Show all commits
.template-lintrc.js
-1
View File
@@ -6,7 +6,6 @@ module.exports = {
rules: {
'simple-unless': false,
'no-nested-interactive': false,
'no-invalid-interactive': false,
'no-html-comments': false
},
app/components/reimbursement-item/template.hbs
+1 -1
View File
@@ -1,6 +1,6 @@
<li data-reimbursement-id={{@reimbursement.id}}
galfert commented 2024-03-20 12:36:11 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

I'm guessing this is the offender why you had to disable the linter rule no-invalid-interactive.

Adding a role="button" to the list element should fix that.

<li data-reimbursement-id={{@reimbursement.id}}
    class="{{item-status @reimbursement}}"
    role="button"
    {{on "click" this.toggleExpenseDetails}}>
I'm guessing this is the offender why you had to disable the linter rule `no-invalid-interactive`. Adding a `role="button"` to the list element should fix that. ```suggestion <li data-reimbursement-id={{@reimbursement.id}} class="{{item-status @reimbursement}}" role="button" {{on "click" this.toggleExpenseDetails}}> ```
class="{{item-status @reimbursement}}"
{{on "click" this.toggleExpenseDetails}}>
role="button" {{on "click" this.toggleExpenseDetails}}>
<p class="meta">
<span class="recipient">
<UserAvatar @contributor={{@reimbursement.contributor}} />