From 0212fa359be42e7860b675a9f72e6d451bae0fb9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A2u=20Cao?= Date: Tue, 27 Jan 2026 12:58:36 +0700 Subject: [PATCH] Change console statements to debug or warn --- app/components/map.gjs | 4 ++-- app/components/places-sidebar.gjs | 6 +++--- app/routes/place.js | 6 +++--- app/services/osm.js | 8 ++++---- app/services/storage.js | 11 ++++------- app/templates/application.gjs | 2 +- app/templates/place.gjs | 2 +- app/templates/place/new.gjs | 2 +- 8 files changed, 19 insertions(+), 22 deletions(-) diff --git a/app/components/map.gjs b/app/components/map.gjs index 5090375..3f6799e 100644 --- a/app/components/map.gjs +++ b/app/components/map.gjs @@ -722,7 +722,7 @@ export default class MapComponent extends Component { if (this.args.isSidebarOpen) { // If it's a bookmark, we allow "switching" to it even if sidebar is open if (clickedBookmark) { - console.log( + console.debug( 'Clicked bookmark while sidebar open (switching):', clickedBookmark ); @@ -739,7 +739,7 @@ export default class MapComponent extends Component { // Normal behavior (sidebar is closed) if (clickedBookmark) { - console.log('Clicked bookmark:', clickedBookmark); + console.debug('Clicked bookmark:', clickedBookmark); this.router.transitionTo('place', clickedBookmark); return; } diff --git a/app/components/places-sidebar.gjs b/app/components/places-sidebar.gjs index c9e95a9..c305ffa 100644 --- a/app/components/places-sidebar.gjs +++ b/app/components/places-sidebar.gjs @@ -50,7 +50,7 @@ export default class PlacesSidebar extends Component { if (confirm(`Delete "${place.title}"?`)) { try { await this.storage.removePlace(place); - console.log('Place deleted:', place.title); + console.debug('Place deleted:', place.title); // Notify parent to refresh map bookmarks if (this.args.onBookmarkChange) { @@ -104,7 +104,7 @@ export default class PlacesSidebar extends Component { try { const savedPlace = await this.storage.storePlace(placeData); - console.log('Place saved:', placeData.title); + console.debug('Place saved:', placeData.title); // Notify parent to refresh map bookmarks if (this.args.onBookmarkChange) { @@ -131,7 +131,7 @@ export default class PlacesSidebar extends Component { async updateBookmark(updatedPlace) { try { const savedPlace = await this.storage.updatePlace(updatedPlace); - console.log('Place updated:', savedPlace.title); + console.debug('Place updated:', savedPlace.title); // Notify parent to refresh map/lists if (this.args.onBookmarkChange) { diff --git a/app/routes/place.js b/app/routes/place.js index bfc4c75..774574f 100644 --- a/app/routes/place.js +++ b/app/routes/place.js @@ -11,7 +11,7 @@ export default class PlaceRoute extends Route { if (id.startsWith('osm:node:') || id.startsWith('osm:way:')) { const [, type, osmId] = id.split(':'); - console.log(`Fetching explicit OSM ${type}:`, osmId); + console.debug(`Fetching explicit OSM ${type}:`, osmId); return this.loadOsmPlace(osmId, type); } @@ -20,7 +20,7 @@ export default class PlaceRoute extends Route { let bookmark = this.storage.findPlaceById(id); if (bookmark) { - console.log('Found in bookmarks:', bookmark.title); + console.debug('Found in bookmarks:', bookmark.title); return bookmark; } @@ -31,7 +31,7 @@ export default class PlaceRoute extends Route { async waitForSync() { if (this.storage.initialSyncDone) return; - console.log('Waiting for initial storage sync...'); + console.debug('Waiting for initial storage sync...'); const timeout = 5000; const start = Date.now(); diff --git a/app/services/osm.js b/app/services/osm.js index 31d0289..9ba722f 100644 --- a/app/services/osm.js +++ b/app/services/osm.js @@ -12,7 +12,7 @@ export default class OsmService extends Service { // Return cached results if the query is identical to the last one if (this.lastQueryKey === queryKey && this.cachedResults) { - console.log('Returning cached Overpass results for:', queryKey); + console.debug('Returning cached Overpass results for:', queryKey); return this.cachedResults; } @@ -52,7 +52,7 @@ out center; return results; } catch (e) { if (e.name === 'AbortError') { - console.log('Overpass request aborted'); + console.debug('Overpass request aborted'); return []; } throw e; @@ -78,7 +78,7 @@ out center; const res = await fetch(url, options); if (!res.ok && retries > 0 && [502, 503, 504, 429].includes(res.status)) { - console.log( + console.warn( `Overpass request failed with ${res.status}. Retrying... (${retries} left)` ); await new Promise((r) => setTimeout(r, 1000)); @@ -88,7 +88,7 @@ out center; return res; } catch (e) { if (retries > 0 && e.name !== 'AbortError') { - console.log(`Retrying Overpass request... (${retries} left)`); + console.debug(`Retrying Overpass request... (${retries} left)`); await new Promise((r) => setTimeout(r, 1000)); return this.fetchWithRetry(url, options, retries - 1); } diff --git a/app/services/storage.js b/app/services/storage.js index 24e2bce..1a26f85 100644 --- a/app/services/storage.js +++ b/app/services/storage.js @@ -23,7 +23,6 @@ export default class StorageService extends Service { constructor() { super(...arguments); - console.log('ohai'); this.rs = new RemoteStorage({ modules: [Places], @@ -45,13 +44,11 @@ export default class StorageService extends Service { }); this.rs.on('connected', () => { - console.debug('Remote storage connected'); this.connected = true; this.userAddress = this.rs.remote.userAddress; }); this.rs.on('disconnected', () => { - console.debug('Remote storage disconnected'); this.connected = false; this.userAddress = null; this.placesInView = []; @@ -128,7 +125,7 @@ export default class StorageService extends Service { // Recalculate prefixes for the current view const required = getGeohashPrefixesInBbox(this.currentBbox); - console.log('Reloading view due to changes, prefixes:', required); + console.debug('Reloading view due to changes, prefixes:', required); // Force load these prefixes (bypassing the 'already loaded' check in loadPlacesInBounds) this.loadAllPlaces(required); @@ -144,11 +141,11 @@ export default class StorageService extends Service { ); if (missingPrefixes.length === 0) { - // console.log('All prefixes already loaded for this view'); + // console.debug('All prefixes already loaded for this view'); return; } - console.log('Loading new prefixes:', missingPrefixes); + console.debug('Loading new prefixes:', missingPrefixes); // 3. Load places for only the new prefixes await this.loadAllPlaces(missingPrefixes); @@ -195,7 +192,7 @@ export default class StorageService extends Service { } else { if (!prefixes) this.placesInView = []; } - console.log('Loaded saved places:', this.placesInView.length); + console.debug('Loaded saved places:', this.placesInView.length); } catch (e) { console.error('Failed to load places:', e); } diff --git a/app/templates/application.gjs b/app/templates/application.gjs index fc013b7..b5487df 100644 --- a/app/templates/application.gjs +++ b/app/templates/application.gjs @@ -28,7 +28,7 @@ export default class ApplicationComponent extends Component { constructor() { super(...arguments); - console.log('Application component constructed'); + console.debug('Application component constructed'); // Access the service to ensure it is instantiated this.storage; } diff --git a/app/templates/place.gjs b/app/templates/place.gjs index 22b7843..a4c869e 100644 --- a/app/templates/place.gjs +++ b/app/templates/place.gjs @@ -63,7 +63,7 @@ export default class PlaceTemplate extends Component { @action handleUpdate(newPlace) { - console.log('Updating local place state:', newPlace); + console.debug('Updating local place state:', newPlace); this.localPlace = newPlace; this.storage.notifyChange(); } diff --git a/app/templates/place/new.gjs b/app/templates/place/new.gjs index 0605beb..6dcbf8f 100644 --- a/app/templates/place/new.gjs +++ b/app/templates/place/new.gjs @@ -45,7 +45,7 @@ export default class PlaceNewTemplate extends Component { }; const savedPlace = await this.storage.storePlace(placeData); - console.log('Created private place:', savedPlace.title); + console.debug('Created private place:', savedPlace.title); // Transition to the new place this.router.replaceWith('place', savedPlace);