Properly handle place removals

* Transition to OSM route or index instead of staying on ghost route/ID
  (closes sidebar if it was a custom place)
* Ensure save button and lists are in the correct state

tests/acceptance/navigation-test.js

@@ -42,6 +42,9 @@ class MockStorageService extends Service {
   findPlaceById() {
     return null;
   }
+  isPlaceSaved() {
+    return false;
+  }
   loadPlacesInBounds() {
     return [];
   }

tests/acceptance/search-test.js

@@ -41,6 +41,9 @@ module('Acceptance | search', function (hooks) {
       findPlaceById() {
         return null;
       }
+      isPlaceSaved() {
+        return false;
+      }
       rs = {
         on: () => {},
       };
@@ -85,6 +88,9 @@ module('Acceptance | search', function (hooks) {
       findPlaceById() {
         return null;
       }
+      isPlaceSaved() {
+        return false;
+      }
       rs = {
         on: () => {},
       };
@@ -130,6 +136,9 @@ module('Acceptance | search', function (hooks) {
         if (id === '999') return this.savedPlaces[0];
         return null;
       }
+      isPlaceSaved(id) {
+        return !!this.findPlaceById(id);
+      }
       rs = {
         on: () => {},
       };

tests/integration/components/place-details-test.gjs

@@ -13,6 +13,14 @@ module('Integration | Component | place-details', function (hooks) {
       { id: 'to-do', title: 'To do', color: '#008000' },
     ];
 
+    isPlaceSaved(id) {
+      return false;
+    }
+
+    findPlaceById(id) {
+      return null;
+    }
+
     async storePlace(place) {
       return { ...place, id: '123', createdAt: new Date().toISOString() };
     }
@@ -28,6 +36,12 @@ module('Integration | Component | place-details', function (hooks) {
 
   hooks.beforeEach(function () {
     this.owner.register('service:storage', StorageService);
+
+    // Mock Router for all tests
+    class MockRouter extends Service {
+      transitionTo() {}
+    }
+    this.owner.register('service:router', MockRouter);
   });
 
   test('it formats coordinates correctly', async function (assert) {
@@ -95,6 +109,12 @@ module('Integration | Component | place-details', function (hooks) {
         storedPlace = place;
         return { ...place, id: 'new-id', createdAt: new Date().toISOString() };
       }
+      isPlaceSaved() {
+        return false;
+      }
+      findPlaceById() {
+        return null;
+      }
     }
     this.owner.register('service:storage', MockStorage);
 
@@ -126,12 +146,15 @@ module('Integration | Component | place-details', function (hooks) {
   });
 
   test('it handles removing a saved place via master toggle', async function (assert) {
-    let removedPlace = null;
+    let removedPlaceId = null;
 
     class MockStorage extends Service {
       lists = [];
       async removePlace(place) {
-        removedPlace = place;
+        removedPlaceId = place.id;
+      }
+      isPlaceSaved() {
+        return true;
       }
     }
     this.owner.register('service:storage', MockStorage);
@@ -160,7 +183,9 @@ module('Integration | Component | place-details', function (hooks) {
     // Click it to remove
     await click(masterToggle);
 
-    assert.strictEqual(removedPlace.id, 'saved-id', 'removePlace was called');
+    assert.strictEqual(removedPlaceId, 'saved-id', 'removePlace was called');
+
+    assert.deepEqual(place._listIds, [], '_listIds was cleared on the object');
   });
 
   test('it adds place to a list', async function (assert) {
@@ -175,6 +200,9 @@ module('Integration | Component | place-details', function (hooks) {
         listId = id;
         shouldAdd = add;
       }
+      isPlaceSaved() {
+        return true;
+      }
     }
     this.owner.register('service:storage', MockStorage);
 
@@ -202,4 +230,29 @@ module('Integration | Component | place-details', function (hooks) {
     assert.strictEqual(placeArg.id, 'p1');
     assert.true(shouldAdd);
   });
+
+  test('it respects storage service state over stale place object', async function (assert) {
+    class MockStorage extends Service {
+      lists = [];
+      isPlaceSaved() {
+        return false;
+      }
+      findPlaceById() {
+        return null;
+      }
+    }
+    this.owner.register('service:storage', MockStorage);
+
+    const place = {
+      id: 'stale-id',
+      title: 'Stale Place',
+      createdAt: '2023-01-01', // Looks saved
+    };
+
+    await render(<template><PlaceDetails @place={{place}} /></template>);
+
+    // Button should say "Save", not "Saved" because isPlaceSaved returns false
+    assert.dom('.actions button').hasText('Save');
+    assert.dom('.actions button').doesNotHaveClass('btn-secondary');
+  });
 });