raucao/marco
1
0
Fork 0
Code Issues 17 Pull Requests Actions Releases 15 Activity

Fix place route being active after closing place details

Browse Source 
Depending on where a place was opened from, it now goes back to the
index or (active) search route
This commit is contained in:
Râu Cao
2026-06-30 18:06:12 +02:00
parent 981502e293
commit 59e334c499
4 changed files with 35 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/acceptance/navigation-test.js
View File

@@ -85,7 +85,7 @@ module('Acceptance | navigation', function (hooks) {
);
});
test('closing the sidebar resets the returnToSearch flag', async function (assert) {
test('closing the sidebar transitions back to search route when opened from search results', async function (assert) {
const mapUi = this.owner.lookup('service:map-ui');
await visit('/search?lat=1&lon=1');
@@ -97,7 +97,22 @@ module('Acceptance | navigation', function (hooks) {
await click('.close-btn');
assert.dom('.sidebar').doesNotExist('Sidebar should be closed');
assert.ok(currentURL().includes('/place/'), 'Remains on place route');
assert.strictEqual(
currentURL(),
'/search?lat=1&lon=1',
'Should transition back to search route'
);
});
test('closing the sidebar when visiting a place directly transitions to index', async function (assert) {
await visit('/place/osm:node:123');
assert.ok(currentURL().includes('/place/'), 'Visited place directly');
// Click the Close (X) button
await click('.close-btn');
assert.dom('.sidebar').doesNotExist('Sidebar should be closed');
assert.strictEqual(currentURL(), '/', 'Should transition back to index');
});
test('navigating directly to place and back closes sidebar', async function (assert) {