From 5fd4ebe184144322b0dcdccf07f40d93318b2cde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kosmos.org>
Date: Fri, 20 Mar 2026 16:55:19 +0400
Subject: [PATCH] Centrally define filled icons

So we don't have to manually pass the option everywhere
---
 app/components/icon.gjs          | 8 ++++++--
 app/components/place-details.gjs | 4 ++--
 app/utils/icons.js               | 6 ++++++
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/app/components/icon.gjs b/app/components/icon.gjs
index 22175f0..2c53914 100644
--- a/app/components/icon.gjs
+++ b/app/components/icon.gjs
@@ -1,6 +1,6 @@
 import Component from '@glimmer/component';
 import { htmlSafe } from '@ember/template';
-import { getIcon } from '../utils/icons';
+import { getIcon, isIconFilled } from '../utils/icons';
 
 export default class IconComponent extends Component {
   get svg() {
@@ -25,10 +25,14 @@ export default class IconComponent extends Component {
     return this.args.title || '';
   }
 
+  get isFilled() {
+    return this.args.filled || isIconFilled(this.args.name);
+  }
+
   <template>
     {{#if this.svg}}
       <span
-        class="icon {{if @filled 'icon-filled'}}"
+        class="icon {{if this.isFilled 'icon-filled'}}"
         style={{this.style}}
         title={{this.title}}
       >
diff --git a/app/components/place-details.gjs b/app/components/place-details.gjs
index 64d0ba7..2f27201 100644
--- a/app/components/place-details.gjs
+++ b/app/components/place-details.gjs
@@ -318,7 +318,7 @@ export default class PlaceDetails extends Component {
 
         {{#if this.cuisine}}
           <p class="content-with-icon">
-            <Icon @name="fork-and-knife" @title="Cuisine" @filled={{true}} />
+            <Icon @name="fork-and-knife" @title="Cuisine" />
             <span>
               {{this.cuisine}}
             </span>
@@ -393,7 +393,7 @@ export default class PlaceDetails extends Component {
 
         {{#if this.wikipedia}}
           <p class="content-with-icon">
-            <Icon @name="wikipedia" @title="Wikipedia" @filled={{true}} />
+            <Icon @name="wikipedia" @title="Wikipedia" />
             <span>
               <a
                 href="https://wikipedia.org/wiki/{{this.wikipedia}}"
diff --git a/app/utils/icons.js b/app/utils/icons.js
index 51f0416..1e90085 100644
--- a/app/utils/icons.js
+++ b/app/utils/icons.js
@@ -64,6 +64,12 @@ const ICONS = {
   zap,
 };
 
+const FILLED_ICONS = ['fork-and-knife', 'wikipedia'];
+
 export function getIcon(name) {
   return ICONS[name];
 }
+
+export function isIconFilled(name) {
+  return FILLED_ICONS.includes(name);
+}