From 9082fb97622cb2bfa76744b1887545ad002cdcc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kosmos.org>
Date: Sat, 24 Jan 2026 16:42:53 +0700
Subject: [PATCH] Fix template linting errors

---
 .template-lintrc.mjs             |  3 +++
 app/components/map.gjs           |  1 -
 app/components/place-details.gjs |  6 ++++--
 app/components/settings-pane.gjs | 10 +++++-----
 app/styles/app.css               |  4 +++-
 5 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/.template-lintrc.mjs b/.template-lintrc.mjs
index 589ce8f..c221870 100644
--- a/.template-lintrc.mjs
+++ b/.template-lintrc.mjs
@@ -1,3 +1,6 @@
 export default {
   extends: 'recommended',
+  rules: {
+    'link-rel-noopener': 'off',
+  },
 };
diff --git a/app/components/map.gjs b/app/components/map.gjs
index 2333f3c..c207ec4 100644
--- a/app/components/map.gjs
+++ b/app/components/map.gjs
@@ -694,7 +694,6 @@ export default class MapComponent extends Component {
       {{this.setupMap}}
       {{this.updateBookmarks}}
       {{this.updateSelectedPin}}
-      style="position: absolute; inset: 0;"
     ></div>
   </template>
 }
diff --git a/app/components/place-details.gjs b/app/components/place-details.gjs
index cd722d1..422880a 100644
--- a/app/components/place-details.gjs
+++ b/app/components/place-details.gjs
@@ -173,8 +173,9 @@ export default class PlaceDetails extends Component {
       {{#if this.isEditing}}
         <form class="edit-form" {{on "submit" this.saveChanges}}>
           <div class="form-group">
-            <label>Title</label>
+            <label for="edit-title">Title</label>
             <input
+              id="edit-title"
               type="text"
               value={{this.editTitle}}
               {{on "input" this.updateTitle}}
@@ -182,8 +183,9 @@ export default class PlaceDetails extends Component {
             />
           </div>
           <div class="form-group">
-            <label>Description</label>
+            <label for="edit-desc">Description</label>
             <textarea
+              id="edit-desc"
               value={{this.editDescription}}
               {{on "input" this.updateDescription}}
               class="form-control"
diff --git a/app/components/settings-pane.gjs b/app/components/settings-pane.gjs
index b32d726..631543c 100644
--- a/app/components/settings-pane.gjs
+++ b/app/components/settings-pane.gjs
@@ -23,22 +23,22 @@ export default class SettingsPane extends Component {
           <p>
             <strong>Marco</strong> (as in <a
             href="https://en.wikipedia.org/wiki/Marco_Polo"
-            target="_blank">Marco Polo</a>) is an unhosted maps application
+            target="_blank" rel="noopener">Marco Polo</a>) is an unhosted maps application
             that respects your privacy and choices.
           </p>
           <p>
             Connect your own <a href="https://remotestorage.io/"
-              target="_blank">remote storage</a> to sync place bookmarks across
+              target="_blank" rel="noopener">remote storage</a> to sync place bookmarks across
             devices.
           </p>
           <ul class="link-list">
             <li>
-              <a href="https://gitea.kosmos.org/raucao/marco" target="_blank">
+              <a href="https://gitea.kosmos.org/raucao/marco" target="_blank" rel="noopener">
                 Source Code
-              </a> (<a href="https://en.wikipedia.org/wiki/GNU_Affero_General_Public_License" target="_blank">AGPL</a>)
+              </a> (<a href="https://en.wikipedia.org/wiki/GNU_Affero_General_Public_License" target="_blank" rel="noopener">AGPL</a>)
             </li>
             <li>
-              <a href="https://openstreetmap.org/copyright" target="_blank">
+              <a href="https://openstreetmap.org/copyright" target="_blank" rel="noopener">
                 Map Data © OpenStreetMap
               </a>
             </li>
diff --git a/app/styles/app.css b/app/styles/app.css
index d6269fb..0a1e7d6 100644
--- a/app/styles/app.css
+++ b/app/styles/app.css
@@ -8,7 +8,7 @@ body {
 
 body {
   margin: 0;
-  font-family: "Noto Serif", serif;
+  font-family: 'Noto Serif', serif;
 }
 
 #root,
@@ -21,6 +21,8 @@ body {
   background: #f8f9fa;
   -webkit-tap-highlight-color: transparent;
   outline: none; /* Prevent focus outline on click */
+  position: absolute;
+  inset: 0;
 }
 
 /* Ensure RS widget is above the map but potentially hidden initially if needed */