Compare commits

...

3 Commits

Author SHA1 Message Date
3a56464926 Improve Nostr connect UI 2026-04-20 13:09:51 +04:00
1dc0c4119b Refactor Nostr auth service 2026-04-20 12:34:44 +04:00
c57a665655 Add applesauce debug logs, fix aggressive connect timeout 2026-04-20 12:14:45 +04:00
3 changed files with 133 additions and 103 deletions

View File

@@ -7,6 +7,7 @@ import qrCode from '../modifiers/qr-code';
export default class NostrConnectComponent extends Component { export default class NostrConnectComponent extends Component {
@service nostrAuth; @service nostrAuth;
@service toast;
get hasExtension() { get hasExtension() {
return typeof window !== 'undefined' && typeof window.nostr !== 'undefined'; return typeof window !== 'undefined' && typeof window.nostr !== 'undefined';
@@ -15,7 +16,8 @@ export default class NostrConnectComponent extends Component {
@action @action
async connectExtension() { async connectExtension() {
try { try {
await this.nostrAuth.login('extension'); await this.nostrAuth.connectWithExtension();
this.toast.show('Nostr connected successfully');
if (this.args.onConnect) { if (this.args.onConnect) {
this.args.onConnect(); this.args.onConnect();
} }
@@ -28,7 +30,8 @@ export default class NostrConnectComponent extends Component {
@action @action
async connectApp() { async connectApp() {
try { try {
await this.nostrAuth.login('connect'); await this.nostrAuth.connectWithApp();
this.toast.show('Nostr connected successfully');
if (this.args.onConnect) { if (this.args.onConnect) {
this.args.onConnect(); this.args.onConnect();
} }
@@ -53,7 +56,7 @@ export default class NostrConnectComponent extends Component {
</button> </button>
{{else}} {{else}}
<button <button
class="btn btn-secondary" class="btn btn-outline"
type="button" type="button"
disabled disabled
title="No Nostr extension found in your browser." title="No Nostr extension found in your browser."
@@ -72,7 +75,7 @@ export default class NostrConnectComponent extends Component {
</div> </div>
{{#if (eq this.nostrAuth.connectStatus "waiting")}} {{#if (eq this.nostrAuth.connectStatus "waiting")}}
<div class="alert alert-info nostr-connect-status"> <div class="nostr-connect-status">
{{#if this.nostrAuth.isMobile}} {{#if this.nostrAuth.isMobile}}
<p>Waiting for you to approve the connection in your mobile signer <p>Waiting for you to approve the connection in your mobile signer
app...</p> app...</p>

View File

@@ -48,7 +48,7 @@ export default class UserMenuComponent extends Component {
@action @action
disconnectNostr() { disconnectNostr() {
this.nostrAuth.logout(); this.nostrAuth.disconnect();
} }
<template> <template>

View File

@@ -12,6 +12,8 @@ const STORAGE_KEY_CONNECT_LOCAL_KEY = 'marco:nostr_connect_local_key';
const STORAGE_KEY_CONNECT_REMOTE_PUBKEY = 'marco:nostr_connect_remote_pubkey'; const STORAGE_KEY_CONNECT_REMOTE_PUBKEY = 'marco:nostr_connect_remote_pubkey';
const STORAGE_KEY_CONNECT_RELAY = 'marco:nostr_connect_relay'; const STORAGE_KEY_CONNECT_RELAY = 'marco:nostr_connect_relay';
const DEFAULT_CONNECT_RELAY = 'wss://relay.nsec.app';
export default class NostrAuthService extends Service { export default class NostrAuthService extends Service {
@service nostrRelay; @service nostrRelay;
@@ -26,6 +28,12 @@ export default class NostrAuthService extends Service {
constructor() { constructor() {
super(...arguments); super(...arguments);
// Enable debug logging for applesauce packages
if (typeof localStorage !== 'undefined') {
localStorage.debug = 'applesauce:*';
}
const saved = localStorage.getItem(STORAGE_KEY); const saved = localStorage.getItem(STORAGE_KEY);
const type = localStorage.getItem(STORAGE_KEY_TYPE); const type = localStorage.getItem(STORAGE_KEY_TYPE);
if (saved) { if (saved) {
@@ -38,7 +46,7 @@ export default class NostrAuthService extends Service {
async _verifyPubkey() { async _verifyPubkey() {
if (this.signerType === 'extension') { if (this.signerType === 'extension') {
if (typeof window.nostr === 'undefined') { if (typeof window.nostr === 'undefined') {
this.logout(); this.disconnect();
return; return;
} }
try { try {
@@ -50,14 +58,14 @@ export default class NostrAuthService extends Service {
} }
} catch (e) { } catch (e) {
console.warn('Failed to verify extension nostr pubkey, logging out', e); console.warn('Failed to verify extension nostr pubkey, logging out', e);
this.logout(); this.disconnect();
} }
} else if (this.signerType === 'connect') { } else if (this.signerType === 'connect') {
try { try {
await this._initConnectSigner(); await this._initConnectSigner();
} catch (e) { } catch (e) {
console.warn('Failed to verify connect nostr pubkey, logging out', e); console.warn('Failed to verify connect nostr pubkey, logging out', e);
this.logout(); this.disconnect();
} }
} }
} }
@@ -93,8 +101,7 @@ export default class NostrAuthService extends Service {
return null; return null;
} }
async login(type = 'extension') { async connectWithExtension() {
if (type === 'extension') {
if (typeof window.nostr === 'undefined') { if (typeof window.nostr === 'undefined') {
throw new Error('No NIP-07 Nostr extension found (e.g., Alby, nos2x).'); throw new Error('No NIP-07 Nostr extension found (e.g., Alby, nos2x).');
} }
@@ -110,11 +117,9 @@ export default class NostrAuthService extends Service {
console.error('Failed to get public key from extension:', error); console.error('Failed to get public key from extension:', error);
throw error; throw error;
} }
} else if (type === 'connect') { }
this.connectStatus = 'waiting';
try { _getLocalSigner() {
// Generate or retrieve a local ephemeral keypair
let localKeyHex = localStorage.getItem(STORAGE_KEY_CONNECT_LOCAL_KEY); let localKeyHex = localStorage.getItem(STORAGE_KEY_CONNECT_LOCAL_KEY);
let localSigner; let localSigner;
if (localKeyHex) { if (localKeyHex) {
@@ -127,11 +132,22 @@ export default class NostrAuthService extends Service {
.join(''); .join('');
localStorage.setItem(STORAGE_KEY_CONNECT_LOCAL_KEY, localKeyHex); localStorage.setItem(STORAGE_KEY_CONNECT_LOCAL_KEY, localKeyHex);
} }
return localSigner;
}
async connectWithApp() {
this.connectStatus = 'waiting';
try {
const localSigner = this._getLocalSigner();
// We use a specific relay for the connection handshake. // We use a specific relay for the connection handshake.
const relay = 'wss://relay.nsec.app'; const relay = DEFAULT_CONNECT_RELAY;
localStorage.setItem(STORAGE_KEY_CONNECT_RELAY, relay); localStorage.setItem(STORAGE_KEY_CONNECT_RELAY, relay);
// Override aggressive 10s EOSE timeout to allow time for QR scanning
this.nostrRelay.pool.relay(relay).eoseTimeout = 180000; // 3 minutes
this._signerInstance = new NostrConnectSigner({ this._signerInstance = new NostrConnectSigner({
pool: this.nostrRelay.pool, pool: this.nostrRelay.pool,
relays: [relay], relays: [relay],
@@ -153,20 +169,30 @@ export default class NostrAuthService extends Service {
this.connectUri = this._signerInstance.getNostrConnectURI({ this.connectUri = this._signerInstance.getNostrConnectURI({
name: 'Marco', name: 'Marco',
url: window.location.origin, url: window.location.origin,
description: 'A privacy-respecting maps application.', description: 'An unhosted maps application.',
icons: [], icons: [],
}); });
// Trigger the deep link intent immediately for the user if on mobile // Trigger the deep link intent immediately for the user if on mobile
if (this.isMobile) { if (this.isMobile) {
console.debug('Mobile detected, triggering deep link intent.');
window.location.href = this.connectUri; window.location.href = this.connectUri;
} }
// Start listening to the relay // Start listening to the relay
console.debug('Opening signer connection to relay...');
await this._signerInstance.open(); await this._signerInstance.open();
console.debug('Signer connection opened successfully.');
// Wait for the remote signer to reply with their pubkey // Wait for the remote signer to reply with their pubkey
console.debug('Waiting for remote signer to ack via relay...');
try {
await this._signerInstance.waitForSigner(); await this._signerInstance.waitForSigner();
console.debug('Remote signer ack received!');
} catch (waitErr) {
console.error('Error while waiting for remote signer ack:', waitErr);
throw waitErr;
}
// Once connected, get the actual user pubkey // Once connected, get the actual user pubkey
this.pubkey = await this._signerInstance.getPublicKey(); this.pubkey = await this._signerInstance.getPublicKey();
@@ -188,21 +214,22 @@ export default class NostrAuthService extends Service {
throw error; throw error;
} }
} }
}
async _initConnectSigner() { async _initConnectSigner() {
const localKeyHex = localStorage.getItem(STORAGE_KEY_CONNECT_LOCAL_KEY);
const remotePubkey = localStorage.getItem( const remotePubkey = localStorage.getItem(
STORAGE_KEY_CONNECT_REMOTE_PUBKEY STORAGE_KEY_CONNECT_REMOTE_PUBKEY
); );
const relay = const relay =
localStorage.getItem(STORAGE_KEY_CONNECT_RELAY) || 'wss://relay.nsec.app'; localStorage.getItem(STORAGE_KEY_CONNECT_RELAY) || DEFAULT_CONNECT_RELAY;
if (!localKeyHex || !remotePubkey) { if (!remotePubkey) {
throw new Error('Missing Nostr Connect local state.'); throw new Error('Missing Nostr Connect remote pubkey.');
} }
const localSigner = PrivateKeySigner.fromKey(localKeyHex); const localSigner = this._getLocalSigner();
// Override aggressive 10s EOSE timeout to allow time for QR scanning
this.nostrRelay.pool.relay(relay).eoseTimeout = 180000; // 3 minutes
this._signerInstance = new NostrConnectSigner({ this._signerInstance = new NostrConnectSigner({
pool: this.nostrRelay.pool, pool: this.nostrRelay.pool,
@@ -237,7 +264,7 @@ export default class NostrAuthService extends Service {
return await this.signer.signEvent(event); return await this.signer.signEvent(event);
} }
async logout() { async disconnect() {
this.pubkey = null; this.pubkey = null;
this.signerType = null; this.signerType = null;
this.connectStatus = null; this.connectStatus = null;