Compare commits

..

3 Commits

Author SHA1 Message Date
raucao 78996b6c61 Refactor sidebar header styles, center icon titles 2026-06-30 14:51:01 +02:00
raucao bb5b69711c Use list colors for list header icons 2026-06-30 14:05:25 +02:00
raucao ad9c489102 Refactor app menu, add place lists
Unify sidebar, make everything route-based
2026-06-30 13:28:48 +02:00
10 changed files with 124 additions and 47 deletions
+2 -2
View File
@@ -3,11 +3,11 @@ import Icon from '#components/icon';
<template> <template>
{{! template-lint-disable no-nested-interactive }} {{! template-lint-disable no-nested-interactive }}
<div class="sidebar-header"> <div class="sidebar-header has-back-btn">
<button type="button" class="back-btn" {{on "click" @onBack}}> <button type="button" class="back-btn" {{on "click" @onBack}}>
<Icon @name="arrow-left" @size={{20}} @color="#333" /> <Icon @name="arrow-left" @size={{20}} @color="#333" />
</button> </button>
<h2>About</h2> <h2 class="sidebar-header-text-centered">About</h2>
<button type="button" class="close-btn" {{on "click" @onClose}}> <button type="button" class="close-btn" {{on "click" @onClose}}>
<Icon @name="x" @size={{20}} @color="#333" /> <Icon @name="x" @size={{20}} @color="#333" />
</button> </button>
+1 -1
View File
@@ -22,7 +22,7 @@ import iconRounded from '../../icons/icon-rounded.svg?raw';
<li> <li>
<button type="button" {{on "click" @onSavedPlaces}}> <button type="button" {{on "click" @onSavedPlaces}}>
<Icon @name="bookmark" @size={{20}} /> <Icon @name="bookmark" @size={{20}} />
<span>Saved places</span> <span>Collections</span>
</button> </button>
</li> </li>
<li> <li>
+2 -2
View File
@@ -21,11 +21,11 @@ export default class AppMenuSettings extends Component {
} }
<template> <template>
<div class="sidebar-header"> <div class="sidebar-header has-back-btn">
<button type="button" class="back-btn" {{on "click" @onBack}}> <button type="button" class="back-btn" {{on "click" @onBack}}>
<Icon @name="arrow-left" @size={{20}} @color="#333" /> <Icon @name="arrow-left" @size={{20}} @color="#333" />
</button> </button>
<h2>Settings</h2> <h2 class="sidebar-header-text-centered">Settings</h2>
<button type="button" class="close-btn" {{on "click" @onClose}}> <button type="button" class="close-btn" {{on "click" @onClose}}>
<Icon @name="x" @size={{20}} @color="#333" /> <Icon @name="x" @size={{20}} @color="#333" />
</button> </button>
+28 -11
View File
@@ -5,6 +5,8 @@ import { on } from '@ember/modifier';
import { fn } from '@ember/helper'; import { fn } from '@ember/helper';
import or from 'ember-truth-helpers/helpers/or'; import or from 'ember-truth-helpers/helpers/or';
import eq from 'ember-truth-helpers/helpers/eq'; import eq from 'ember-truth-helpers/helpers/eq';
import and from 'ember-truth-helpers/helpers/and';
import not from 'ember-truth-helpers/helpers/not';
import PlaceDetails from './place-details'; import PlaceDetails from './place-details';
import Icon from './icon'; import Icon from './icon';
import humanizeOsmTag from '../helpers/humanize-osm-tag'; import humanizeOsmTag from '../helpers/humanize-osm-tag';
@@ -161,7 +163,11 @@ export default class PlacesSidebar extends Component {
<template> <template>
<div class="sidebar"> <div class="sidebar">
<div class="sidebar-header {{if this.hasHeaderPhoto 'no-border'}}"> <div
class="sidebar-header
{{if this.hasHeaderPhoto 'no-border'}}
{{if (and (not @selectedPlace) @onBack) 'has-back-btn'}}"
>
{{#if @selectedPlace}} {{#if @selectedPlace}}
<button <button
type="button" type="button"
@@ -170,20 +176,31 @@ export default class PlacesSidebar extends Component {
><Icon @name="arrow-left" @size={{20}} @color="#333" /></button> ><Icon @name="arrow-left" @size={{20}} @color="#333" /></button>
{{else}} {{else}}
{{#if @onBack}} {{#if @onBack}}
<button <button type="button" class="back-btn" {{on "click" @onBack}}><Icon
type="button" @name="arrow-left"
class="back-btn" @size={{20}}
{{on "click" @onBack}} @color="#333"
><Icon @name="arrow-left" @size={{20}} @color="#333" /></button> /></button>
{{/if}} {{/if}}
{{#if @title}} {{#if @onBack}}
<h2><Icon @name="bookmark" @size={{20}} @color="#333" /> <h2 class="sidebar-header-text-centered">
{{@title}}</h2> <span class="sidebar-header-icon-wrapper">
{{else if this.isNearbySearch}} <Icon
@name="bookmark"
@size={{20}}
@color={{or @color "#898989"}}
/>
</span>
{{@title}}
</h2>
{{else}}
{{#if this.isNearbySearch}}
<h2><Icon @name="target" @size={{20}} @color="#ea4335" /> <h2><Icon @name="target" @size={{20}} @color="#ea4335" />
Nearby</h2> Nearby</h2>
{{else}} {{else}}
<h2><Icon @name="search" @size={{20}} @color="#333" /> Results</h2> <h2><Icon @name="search" @size={{20}} @color="#333" />
Results</h2>
{{/if}}
{{/if}} {{/if}}
{{/if}} {{/if}}
<button type="button" class="close-btn" {{on "click" @onClose}}><Icon <button type="button" class="close-btn" {{on "click" @onClose}}><Icon
+44 -8
View File
@@ -115,8 +115,6 @@ body {
display: flex; display: flex;
align-items: center; align-items: center;
grid-area: search; grid-area: search;
/* Ensure it sits at the start of its grid area */
justify-self: start; justify-self: start;
width: 100%; width: 100%;
} }
@@ -130,7 +128,6 @@ body {
@media (width > 768px) { @media (width > 768px) {
.header-left { .header-left {
/* Desktop: Ensure minimum width for search box so it's not squeezed */
min-width: 300px; min-width: 300px;
max-width: 350px; max-width: 350px;
} }
@@ -143,8 +140,6 @@ body {
.header-center { .header-center {
grid-area: chips; grid-area: chips;
/* Desktop: Center the chips block in the available space */
display: flex; display: flex;
justify-content: center; justify-content: center;
min-width: 0; /* Allow shrinking */ min-width: 0; /* Allow shrinking */
@@ -159,7 +154,6 @@ body {
} }
@media (width <= 768px) { @media (width <= 768px) {
/* No need to reset min-width/max-width since they are only set in media query above */
.header-center { .header-center {
width: 100%; width: 100%;
overflow: hidden; overflow: hidden;
@@ -486,11 +480,13 @@ body {
} }
.sidebar-header { .sidebar-header {
padding: 1rem; height: 56px; /* Strictly enforce identical vertical height */
padding: 0 1rem; /* Keep horizontal padding, remove vertical padding */
border-bottom: 1px solid var(--divider-color); border-bottom: 1px solid var(--divider-color);
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;
align-items: center; align-items: center;
box-sizing: border-box; /* Guarantee strict height boundaries */
} }
.sidebar-header.no-border { .sidebar-header.no-border {
@@ -499,7 +495,7 @@ body {
.sidebar-header h2 { .sidebar-header h2 {
margin: 0; margin: 0;
font-size: 1.2rem; font-size: 1.1rem;
display: flex; display: flex;
align-items: center; align-items: center;
gap: 0.5rem; gap: 0.5rem;
@@ -2214,3 +2210,43 @@ button.create-place {
white-space: nowrap; white-space: nowrap;
flex-shrink: 0; flex-shrink: 0;
} }
/* Centered layout when back button is present */
.sidebar-header.has-back-btn {
position: relative;
justify-content: center; /* Center horizontally */
}
/* Absolute positioning for buttons in centered header */
.sidebar-header.has-back-btn .back-btn {
position: absolute;
left: 1rem;
z-index: 10;
}
.sidebar-header.has-back-btn .close-btn {
position: absolute;
right: 1rem;
z-index: 10;
}
/* Centralized Title text */
.sidebar-header-text-centered {
position: relative;
margin: 0;
font-size: 1.2rem;
font-weight: bold;
display: inline-flex;
align-items: center;
justify-content: center;
text-align: center;
max-width: 60%;
}
.sidebar-header-icon-wrapper {
position: absolute;
right: 100%;
margin-right: 0.5rem;
display: flex;
align-items: center;
}
-3
View File
@@ -2,12 +2,9 @@ import Component from '@glimmer/component';
import { pageTitle } from 'ember-page-title'; import { pageTitle } from 'ember-page-title';
import Map from '#components/map'; import Map from '#components/map';
import AppHeader from '#components/app-header'; import AppHeader from '#components/app-header';
import AppMenu from '#components/app-menu/index';
import Toast from '#components/toast'; import Toast from '#components/toast';
import { service } from '@ember/service'; import { service } from '@ember/service';
import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object'; import { action } from '@ember/object';
import { or } from 'ember-truth-helpers';
import { on } from '@ember/modifier'; import { on } from '@ember/modifier';
export default class ApplicationComponent extends Component { export default class ApplicationComponent extends Component {
+1 -7
View File
@@ -1,7 +1 @@
import Component from '@glimmer/component'; <template>{{outlet}}</template>
export default class ListsTemplate extends Component {
<template>
{{outlet}}
</template>
}
+21 -4
View File
@@ -4,12 +4,22 @@ import { action } from '@ember/object';
import { fn } from '@ember/helper'; import { fn } from '@ember/helper';
import { on } from '@ember/modifier'; import { on } from '@ember/modifier';
import Icon from '#components/icon'; import Icon from '#components/icon';
import { htmlSafe } from '@ember/template';
export default class ListsIndexTemplate extends Component { export default class ListsIndexTemplate extends Component {
@service storage; @service storage;
@service router; @service router;
@service mapUi; @service mapUi;
styleFor(color) {
const finalColor =
color ||
getComputedStyle(document.documentElement)
.getPropertyValue('--default-list-color')
.trim();
return htmlSafe(`background-color: ${finalColor}`);
}
@action @action
selectList(listId) { selectList(listId) {
this.router.transitionTo('lists.list', listId); this.router.transitionTo('lists.list', listId);
@@ -28,11 +38,16 @@ export default class ListsIndexTemplate extends Component {
<template> <template>
{{#if this.mapUi.isSidebarVisible}} {{#if this.mapUi.isSidebarVisible}}
<div class="sidebar"> <div class="sidebar">
<div class="sidebar-header"> <div class="sidebar-header has-back-btn">
<button type="button" class="back-btn" {{on "click" this.backToMenu}}> <button type="button" class="back-btn" {{on "click" this.backToMenu}}>
<Icon @name="arrow-left" @size={{20}} @color="#333" /> <Icon @name="arrow-left" @size={{20}} @color="#333" />
</button> </button>
<h2><Icon @name="bookmark" @size={{20}} @color="#333" /> Saved places</h2> <h2 class="sidebar-header-text-centered">
<span class="sidebar-header-icon-wrapper">
<Icon @name="bookmark" @size={{20}} @color="#898989" />
</span>
Collections
</h2>
<button type="button" class="close-btn" {{on "click" this.close}}> <button type="button" class="close-btn" {{on "click" this.close}}>
<Icon @name="x" @size={{20}} @color="#333" /> <Icon @name="x" @size={{20}} @color="#333" />
</button> </button>
@@ -48,15 +63,17 @@ export default class ListsIndexTemplate extends Component {
{{on "click" (fn this.selectList list.id)}} {{on "click" (fn this.selectList list.id)}}
> >
<div class="lists-index-item-left"> <div class="lists-index-item-left">
{{! template-lint-disable no-inline-styles }}
<span <span
class="list-color-dot" class="list-color-dot"
style="background-color: {{list.color}}" style={{this.styleFor list.color}}
></span> ></span>
<div class="lists-index-name">{{list.title}}</div> <div class="lists-index-name">{{list.title}}</div>
</div> </div>
<div class="lists-index-count"> <div class="lists-index-count">
{{#if list.placeRefs.length}} {{#if list.placeRefs.length}}
{{list.placeRefs.length}} places {{list.placeRefs.length}}
places
{{else}} {{else}}
empty empty
{{/if}} {{/if}}
+22 -4
View File
@@ -16,18 +16,32 @@ export default class ListsListTemplate extends Component {
return this.mapUi.getScrollPosition(`list-${this.listId}`); return this.mapUi.getScrollPosition(`list-${this.listId}`);
} }
get listColor() {
const list = this.storage.lists.find((l) => l.id === this.listId);
if (list && list.color) {
return list.color;
}
return getComputedStyle(document.documentElement)
.getPropertyValue('--default-list-color')
.trim();
}
get listTitle() { get listTitle() {
const list = this.storage.lists.find((l) => l.id === this.listId); const list = this.storage.lists.find((l) => l.id === this.listId);
return list ? list.title : 'Saved places'; return list ? list.title : 'Collections';
} }
get places() { get places() {
const modelPlaces = this.args.model?.places || []; const modelPlaces = this.args.model?.places || [];
const currentList = this.storage.lists.find((l) => l.id === this.listId); const currentList = this.storage.lists.find((l) => l.id === this.listId);
const placeRefsIds = new Set(currentList?.placeRefs?.map((ref) => ref.id) || []); const placeRefsIds = new Set(
currentList?.placeRefs?.map((ref) => ref.id) || []
);
// Filter live tracked savedPlaces that are in this list // Filter live tracked savedPlaces that are in this list
const livePlaces = this.storage.savedPlaces.filter((p) => placeRefsIds.has(p.id)); const livePlaces = this.storage.savedPlaces.filter((p) =>
placeRefsIds.has(p.id)
);
const merged = []; const merged = [];
const seen = new Set(); const seen = new Set();
@@ -54,7 +68,10 @@ export default class ListsListTemplate extends Component {
if (place) { if (place) {
const sidebarContent = document.querySelector('.sidebar-content'); const sidebarContent = document.querySelector('.sidebar-content');
if (sidebarContent) { if (sidebarContent) {
this.mapUi.saveScrollPosition(`list-${this.listId}`, sidebarContent.scrollTop); this.mapUi.saveScrollPosition(
`list-${this.listId}`,
sidebarContent.scrollTop
);
} }
this.mapUi.returnToRoute = { this.mapUi.returnToRoute = {
name: 'lists.list', name: 'lists.list',
@@ -81,6 +98,7 @@ export default class ListsListTemplate extends Component {
<PlacesSidebar <PlacesSidebar
@places={{this.places}} @places={{this.places}}
@title={{this.listTitle}} @title={{this.listTitle}}
@color={{this.listColor}}
@scrollTop={{this.scrollTop}} @scrollTop={{this.scrollTop}}
@onSelect={{this.selectPlace}} @onSelect={{this.selectPlace}}
@onClose={{this.close}} @onClose={{this.close}}
+1 -3
View File
@@ -11,7 +11,5 @@ export default class MenuTemplate extends Component {
this.router.transitionTo('index'); this.router.transitionTo('index');
} }
<template> <template><AppMenu @onClose={{this.close}} /></template>
<AppMenu @onClose={{this.close}} />
</template>
} }