I randomly thought about this again earlier today, and I'm actually not sure why the PR had to include firewall rules and such.
If we don't run the basic cookbook against the host again, then it won't destroy the existing ones for example. So this could actually have been two different PRs, one for the script itself, and one for the firewall config, as they are two different features.
You can still split it up, of course, but maybe now it's not worth it anymore. So just putting this here as input, and perhaps for the next PRs.
This doesn't look right to me. It would attempt to download the path as a second file, no? The pathname should come after the -o flag.
Same as for the other cookbook, this seems to have been left unedited after being generated.
We won't want to edit the script on the host all the time, so why not simply:
I think adding a whole license text to every recipe is complete overkill. Why not have a single LICENSE file at the repo root, like with every other software repo these days? What's the benefit of adding the license to every recipe file (but not other files)?
Is this file actually used? We're on 20.04 now so it seems like this is some default template?
44fadb12d6
Merge pull request 'Update link to Chat service' (#11) from chore/update_service_link into master