I also stumbled over this config, but only in (lots of) examples, but not in the official docs:
bad_servers:
server:
- "gmail.com"
I randomly thought about this again earlier today, and I'm actually not sure why the PR had to include firewall rules and such.
If we don't run the basic cookbook against the host again, then it won't destroy the existing ones for example. So this could actually have been two different PRs, one for the script itself, and one for the firewall config, as they are two different features.
You can still split it up, of course, but maybe now it's not worth it anymore. So just putting this here as input, and perhaps for the next PRs.
This doesn't look right to me. It would attempt to download the path as a second file, no? The pathname should come after the -o flag.
We won't want to edit the script on the host all the time, so why not simply:
Same as for the other cookbook, this seems to have been left unedited after being generated.
Is this file actually used? We're on 20.04 now so it seems like this is some default template?