5apps/liquor-cabinet
5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Merge pull request #122 from 5apps/bugfix/121-set_content_type_on_head

Browse Source 
Set Content-Type header on HEAD requests
This commit is contained in:
Basti 2018-05-22 12:11:51 +02:00 committed by GitHub
commit 28f003c20b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/remote_storage/rest_provider.rb
View File

@ -44,8 +44,9 @@ module RemoteStorage
server.halt 404 if metadata.empty?
# Set the response headers for a 304 or 200 response
server.headers["ETag"] = %Q("#{metadata["e"]}")
server.headers["Last-Modified"] = Time.at(metadata["m"].to_i / 1000).httpdate
server.headers["ETag"] = %Q("#{metadata["e"]}")
server.headers["Last-Modified"] = Time.at(metadata["m"].to_i / 1000).httpdate
server.headers["Content-Type"] = metadata["t"]
if none_match.include? %Q("#{metadata["e"]}")
server.halt 304

2
spec/shared_examples.rb
View File

@ -614,6 +614,8 @@ shared_examples_for 'a REST adapter' do
last_response.status.must_equal 200
last_response.headers["ETag"].must_equal "\"0815etag\""
last_response.headers["Cache-Control"].must_equal "no-cache"
last_response.headers["Last-Modified"].must_equal "Fri, 04 Mar 2016 12:20:18 GMT"
last_response.headers["Content-Type"].must_equal "text/plain; charset=utf-8"
end
it "responds with 304 when IF_NONE_MATCH header contains the ETag" do