5apps/liquor-cabinet
5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Switch to AWS v4 signatures #5

Merged
basti merged 9 commits from feature/aws_v4_signatures into master 2023-11-21 14:19:38 +00:00
Conversation 1 Commits 9 Files Changed 7 +47 -50
basti commented 2023-11-15 18:16:15 +00:00
Owner
Copy Link

closes #3

closes #3
basti added 3 commits 2023-11-15 18:16:16 +00:00
raucao added 1 commit 2023-11-16 10:15:01 +00:00
raucao added 1 commit 2023-11-16 10:27:35 +00:00
raucao added 1 commit 2023-11-16 10:39:46 +00:00
raucao added 1 commit 2023-11-16 10:42:12 +00:00
raucao added 1 commit 2023-11-16 10:45:25 +00:00
raucao added 1 commit 2023-11-16 11:40:03 +00:00
galfert approved these changes 2023-11-21 13:18:15 +00:00
galfert left a comment
Owner
Copy Link

Looks all good to me 👍

Looks all good to me 👍
Dockerfile
@ -3,3 +2,3 @@
WORKDIR /liquorcabinet
ENV RACK_ENV=staging
ENV RACK_ENV=production
galfert commented 2023-11-21 12:56:59 +00:00
Owner
Copy Link

Is this change intentional?

Is this change intentional?
basti commented 2023-11-21 14:19:03 +00:00
Author
Owner
Copy Link

Yes, I think default should be production.

Yes, I think default should be production.
basti marked this conversation as resolved
lib/remote_storage/s3.rb Outdated
@ -89,3 +78,1 @@
def hmac(key, value)
OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha1'), key, value)
def auth_headers_for(http_method, url, headers, data = nil)
galfert commented 2023-11-21 13:15:43 +00:00
Owner
Copy Link

The headers param could be made optional as well, then you wouldn't need to add an empty hash for the calls in do_head_request and do_delete_request.

auth_headers_for(http_method, url, headers = {}, data = nil)
The `headers` param could be made optional as well, then you wouldn't need to add an empty hash for the calls in `do_head_request` and `do_delete_request`. ```rb auth_headers_for(http_method, url, headers = {}, data = nil) ```
basti marked this conversation as resolved
raucao added 1 commit 2023-11-21 14:18:26 +00:00
basti merged commit 8b6f201a0b into master 2023-11-21 14:19:38 +00:00
basti deleted branch feature/aws_v4_signatures 2023-11-21 14:19:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
bug
Something is not working
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
question
Looking for an answer
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
basti galfert greg raucao
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 5apps/liquor-cabinet#5
No description provided.
Delete Branch "feature/aws_v4_signatures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?