5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Switch to AWS v4 signatures #5

Merged
basti merged 9 commits from feature/aws_v4_signatures into master 2023-11-21 14:19:38 +00:00
Conversation 1 Commits 9 Files Changed 7
+47 -50
basti commented 2023-11-15 18:16:15 +00:00
Owner
Copy Link
Copy Source

closes #3

closes #3
basti added 3 commits 2023-11-15 18:16:16 +00:00
Add Dockerfile 273768ea69
Add example script for running server in dev 189c304a08
Switch to AWS V4 signatures 02820203f0
raucao added 1 commit 2023-11-16 10:15:01 +00:00
Remove debug output, rescue b7ff3e7d42
raucao added 1 commit 2023-11-16 10:27:35 +00:00
Use development env and Webrick in dev run script 96417e3884
raucao added 1 commit 2023-11-16 10:39:46 +00:00
Expose Content-Type header 024f516a9d
raucao added 1 commit 2023-11-16 10:42:12 +00:00
Use production env for Docker image d09c6e7a39
raucao added 1 commit 2023-11-16 10:45:25 +00:00
Switch Docker image back to Ruby 3.1 91cadbf228
raucao added 1 commit 2023-11-16 11:40:03 +00:00
Update example config 589dcf7fa2
galfert approved these changes 2023-11-21 13:18:15 +00:00
galfert left a comment
Owner
Copy Link
Copy Source

Looks all good to me 👍

Looks all good to me 👍
Dockerfile
@@ -3,3 +2,3 @@
WORKDIR /liquorcabinet
ENV RACK_ENV=staging
ENV RACK_ENV=production
galfert commented 2023-11-21 12:56:59 +00:00
Owner
Copy Link
Copy Source

Is this change intentional?

Is this change intentional?
basti commented 2023-11-21 14:19:03 +00:00
Author
Owner
Copy Link
Copy Source

Yes, I think default should be production.

Yes, I think default should be production.
basti marked this conversation as resolved
lib/remote_storage/s3.rb Outdated
@@ -89,3 +78,1 @@
def hmac(key, value)
OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha1'), key, value)
def auth_headers_for(http_method, url, headers, data = nil)
galfert commented 2023-11-21 13:15:43 +00:00
Owner
Copy Link
Copy Source

The headers param could be made optional as well, then you wouldn't need to add an empty hash for the calls in do_head_request and do_delete_request.

auth_headers_for(http_method, url, headers = {}, data = nil)
The `headers` param could be made optional as well, then you wouldn't need to add an empty hash for the calls in `do_head_request` and `do_delete_request`. ```rb auth_headers_for(http_method, url, headers = {}, data = nil) ```
basti marked this conversation as resolved
raucao added 1 commit 2023-11-21 14:18:26 +00:00
Make headers argument optional 209fcca5ea
basti merged commit 8b6f201a0b into master 2023-11-21 14:19:38 +00:00
basti deleted branch feature/aws_v4_signatures 2023-11-21 14:19:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
basti (Basti) galfert (galfert) greg (Greg) raucao (Râu Cao)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 5apps/liquor-cabinet#5