5apps/liquor-cabinet
5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Switch to AWS v4 signatures #5

Merged
basti merged 9 commits from feature/aws_v4_signatures into master 2023-11-21 14:19:38 +00:00
Conversation 1 Commits 9 Files Changed 7 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 209fcca5ea - Show all commits

6
lib/remote_storage/s3.rb
View File

@ -49,14 +49,14 @@ module RemoteStorage
def do_head_request(url, &block)
deal_with_unauthorized_requests do
auth_headers = auth_headers_for("HEAD", url, {})
auth_headers = auth_headers_for("HEAD", url)
RestClient.head(url, auth_headers, &block)
end
end
def do_delete_request(url)
deal_with_unauthorized_requests do
auth_headers = auth_headers_for("DELETE", url, {})
auth_headers = auth_headers_for("DELETE", url)
RestClient.delete(url, auth_headers)
end
end
@ -75,7 +75,7 @@ module RemoteStorage
return found
end
def auth_headers_for(http_method, url, headers, data = nil)
def auth_headers_for(http_method, url, headers = {}, data = nil)
basti marked this conversation as resolved Outdated
galfert commented 2023-11-21 13:15:43 +00:00
Outdated
Review
Copy Link

The headers param could be made optional as well, then you wouldn't need to add an empty hash for the calls in do_head_request and do_delete_request.

auth_headers_for(http_method, url, headers = {}, data = nil)
The `headers` param could be made optional as well, then you wouldn't need to add an empty hash for the calls in `do_head_request` and `do_delete_request`. ```rb auth_headers_for(http_method, url, headers = {}, data = nil) ```
signature = s3_signer.sign_request(
http_method: http_method, url: url, headers: headers, body: data
)