5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Fix invalid PUT signatures for URI-encoded paths #9

Merged
basti merged 3 commits from bugfix/8-signatures into master 2024-03-05 15:55:50 +00:00
Conversation 0 Commits 3 Files Changed 3
+18 -34
basti commented 2024-03-04 16:21:01 +00:00
Owner
Copy Link
Copy Source

We encode the URLs ourselves, and the default option for the aws-sigv4 gem breaks that functionality.

fixes #8

We encode the URLs ourselves, and the default option for the `aws-sigv4` gem breaks that functionality. fixes #8
basti added the bug label 2024-03-04 16:21:01 +00:00
basti added 1 commit 2024-03-04 16:21:01 +00:00
Fix invalid PUT signatures for URI-encoded paths
Tests / test (6, 2.7) (pull_request) Failing after 19s
Tests / test (6, 3.0) (pull_request) Failing after 3s
Tests / test (6, 3.1) (pull_request) Failing after 3s
Tests / test (7, 2.7) (pull_request) Failing after 3s
Tests / test (7, 3.0) (pull_request) Failing after 3s
Tests / test (7, 3.1) (pull_request) Failing after 3s
bf14785404 
We encode the URLs ourselves, and the default option for the aws-sigv4
gem breaks that functionality.
basti added 2 commits 2024-03-05 13:30:05 +00:00
Set up Drone CI, remove Actions configs
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
6455f24ab0
Merge pull request 'Set up Drone CI, remove Actions configs' (#11) from dev/actions into bugfix/8-signatures
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
aff383b99b 
Reviewed-on: #11
basti merged commit 3512c0f7c9 into master 2024-03-05 15:55:50 +00:00
basti deleted branch bugfix/8-signatures 2024-03-05 15:55:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Assignees
Clear assignees
basti (Basti) galfert (galfert) greg (Greg) raucao (Râu Cao)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 5apps/liquor-cabinet#9