5apps/manifique
5apps/manifique
4
0
Fork 0
Code Issues Pull Requests Releases 3 Activity

Make client's internal methods private

Browse Source
This commit is contained in:
Basti 2018-07-04 08:58:49 +02:00
parent 3f6f79c111
commit cee7f7e174
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/manifique/web_client.rb
View File

@ -26,6 +26,8 @@ module Manifique
@metadata @metadata
end end
private
def fetch_website def fetch_website
res = do_get_request @url res = do_get_request @url
@html = Nokogiri::HTML(res.body) @html = Nokogiri::HTML(res.body)
@ -46,8 +48,6 @@ module Manifique
JSON.parse(res.body) JSON.parse(res.body)
end end
private
def parse_metadata_from_html def parse_metadata_from_html
parse_title_from_html parse_title_from_html
parse_meta_elements_from_html parse_meta_elements_from_html

10
spec/manifique/web_client_spec.rb
View File

@ -60,7 +60,7 @@ RSpec.describe Manifique::WebClient do
"Content-Type": "text/html; charset=utf-8" "Content-Type": "text/html; charset=utf-8"
}) })
web_client.fetch_website web_client.send(:fetch_website)
end end
it "instantiates an HTML parser object" do it "instantiates an HTML parser object" do
@ -86,11 +86,11 @@ RSpec.describe Manifique::WebClient do
"Content-Type": "application/json; charset=utf-8" "Content-Type": "application/json; charset=utf-8"
}) })
web_client.fetch_website web_client.send(:fetch_website)
end end
subject do subject do
web_client.fetch_web_manifest web_client.send(:fetch_web_manifest)
end end
it "returns the fetched manifest as a hash" do it "returns the fetched manifest as a hash" do
@ -107,11 +107,11 @@ RSpec.describe Manifique::WebClient do
"Content-Type": "text/html; charset=utf-8" "Content-Type": "text/html; charset=utf-8"
}) })
web_client.fetch_website web_client.send(:fetch_website)
end end
subject do subject do
web_client.fetch_web_manifest web_client.send(:fetch_web_manifest)
end end
it "returns false" do it "returns false" do